runtime: netpoll_windows fails to build on windows-arm

[bcmills]

From https://build.golang.org/log/9ce72620b62df52a4a11332df8cf40c65f23a798:

Building Go bootstrap cmd/go (go_bootstrap) using Go toolchain1.
d:\workdir\go\src\runtime\netpoll_windows.go:19:4: undefined: overlapped

go tool dist: FAILED: d:\workdir\go\pkg\tool\windows_arm\compile -std -pack -o C:\Data\SystemData\Temp\go-tool-dist-781085415\runtime\_go_.a -p runtime -+ -asmhdr C:\Data\SystemData\Temp\go-tool-dist-781085415\runtime\go_asm.h d:\workdir\go\src\runtime\alg.go d:\workdir\go\src\runtime\atomic_pointer.go d:\workdir\go\src\runtime\auxv_none.go d:\workdir\go\src\runtime\cgo.go d:\workdir\go\src\runtime\cgocall.go d:\workdir\go\src\runtime\cgocallback.go d:\workdir\go\src\runtime\cgocheck.go d:\workdir\go\src\runtime\chan.go d:\workdir\go\src\runtime\compiler.go d:\workdir\go\src\runtime\complex.go d:\workdir\go\src\runtime\cpuflags.go d:\workdir\go\src\runtime\cpuprof.go d:\workdir\go\src\runtime\debug.go d:\workdir\go\src\runtime\env_posix.go d:\workdir\go\src\runtime\error.go d:\workdir\go\src\runtime\extern.go d:\workdir\go\src\runtime\fastlog2.go d:\workdir\go\src\runtime\fastlog2table.go d:\workdir\go\src\runtime\float.go d:\workdir\go\src\runtime\hash32.go d:\workdir\go\src\runtime\heapdump.go d:\workdir\go\src\runtime\iface.go d:\workdir\go\src\runtime\lfstack.go d:\workdir\go\src\runtime\lfstack_32bit.go d:\workdir\go\src\runtime\lock_sema.go d:\workdir\go\src\runtime\malloc.go d:\workdir\go\src\runtime\map.go d:\workdir\go\src\runtime\map_fast32.go d:\workdir\go\src\runtime\map_fast64.go d:\workdir\go\src\runtime\map_faststr.go d:\workdir\go\src\runtime\mbarrier.go d:\workdir\go\src\runtime\mbitmap.go d:\workdir\go\src\runtime\mcache.go d:\workdir\go\src\runtime\mcentral.go d:\workdir\go\src\runtime\mem_windows.go d:\workdir\go\src\runtime\mfinal.go d:\workdir\go\src\runtime\mfixalloc.go d:\workdir\go\src\runtime\mgc.go d:\workdir\go\src\runtime\mgclarge.go d:\workdir\go\src\runtime\mgcmark.go d:\workdir\go\src\runtime\mgcsweep.go d:\workdir\go\src\runtime\mgcsweepbuf.go d:\workdir\go\src\runtime\mgcwork.go d:\workdir\go\src\runtime\mheap.go d:\workdir\go\src\runtime\mprof.go d:\workdir\go\src\runtime\msan0.go d:\workdir\go\src\runtime\msize.go d:\workdir\go\src\runtime\mstats.go d:\workdir\go\src\runtime\mwbbuf.go d:\workdir\go\src\runtime\netpoll.go d:\workdir\go\src\runtime\netpoll_windows.go d:\workdir\go\src\runtime\os_nonopenbsd.go d:\workdir\go\src\runtime\os_windows.go d:\workdir\go\src\runtime\panic.go d:\workdir\go\src\runtime\plugin.go d:\workdir\go\src\runtime\print.go d:\workdir\go\src\runtime\proc.go d:\workdir\go\src\runtime\profbuf.go d:\workdir\go\src\runtime\proflabel.go d:\workdir\go\src\runtime\race0.go d:\workdir\go\src\runtime\rdebug.go d:\workdir\go\src\runtime\runtime.go d:\workdir\go\src\runtime\runtime1.go d:\workdir\go\src\runtime\runtime2.go d:\workdir\go\src\runtime\rwmutex.go d:\workdir\go\src\runtime\select.go d:\workdir\go\src\runtime\sema.go d:\workdir\go\src\runtime\signal_windows.go d:\workdir\go\src\runtime\sigqueue.go d:\workdir\go\src\runtime\sizeclasses.go d:\workdir\go\src\runtime\slice.go d:\workdir\go\src\runtime\softfloat64.go d:\workdir\go\src\runtime\stack.go d:\workdir\go\src\runtime\string.go d:\workdir\go\src\runtime\stubs.go d:\workdir\go\src\runtime\stubs32.go d:\workdir\go\src\runtime\stubs_arm.go d:\workdir\go\src\runtime\stubs_nonlinux.go d:\workdir\go\src\runtime\symtab.go d:\workdir\go\src\runtime\sys_arm.go d:\workdir\go\src\runtime\sys_nonppc64x.go d:\workdir\go\src\runtime\syscall_windows.go d:\workdir\go\src\runtime\time.go d:\workdir\go\src\runtime\timeasm.go d:\workdir\go\src\runtime\trace.go d:\workdir\go\src\runtime\traceback.go d:\workdir\go\src\runtime\type.go d:\workdir\go\src\runtime\typekind.go d:\workdir\go\src\runtime\unaligned2.go d:\workdir\go\src\runtime\utf8.go d:\workdir\go\src\runtime\vdso_in_none.go d:\workdir\go\src\runtime\vlrt.go d:\workdir\go\src\runtime\write_err.go d:\workdir\go\src\runtime\zcallback_windows.go: exit status 2
go tool dist: open C:\Data\SystemData\Temp\go-tool-dist-781085415\runtime\_go_.a: The system cannot find the file specified.
The system cannot find the batch label specified - fail

CC: @alexbrainman @ianlancetaylor @aclements @randall77

[ianlancetaylor]

Someone needs to generate internal/poll/defs_windows_arm.go.

Isn't this just a subset of #26148? And in fact CL 128715 should fix this. Do we need a separate issue for this?

[bcmills]

Isn't this just a subset of #26148? And in fact CL 128715 should fix this. Do we need a separate issue for this?

No idea. I was just looking at the builders and assuming that anything present with “show only first-class ports” checked should pass.

If we're adding new builders for ports that don't work yet, arguably they should not be classified as “first-class”. Perhaps the windows-arm builder is misclassified?

[alexbrainman]

d:\workdir\go\src\runtime\netpoll_windows.go:19:4: undefined: overlapped

As far as I can tell, the fix is in

https://go-review.googlesource.com/c/go/+/128715

It is up to us to +2 and submit it. Ian asked for some changes, which Jordan replied to. Ian, please, +2 and submit, if you are OK with CL. Thank you.

Alex

[alexbrainman]

CL 128715 was submitted. Current build https://build.golang.org/log/391237e5d9a43cb80e9d427b8046dc9e29157f9d gets past the

go tool dist: FAILED: d:\workdir\go\pkg\tool\windows_arm\compile -std -pack -o C:\Data\SystemData\Temp\go-tool-dist-781085415\runtime_go_.a -p runtime -+ -asmhdr C:\Data\SystemData\Temp\go-tool-dist-781085415\runtime\go_asm.h d:\workdir\go\src\runtime\alg.go d:\workdir\go\src\runtime\atomic_pointer.go d:\workdir\go\src\runtime\auxv_none.go d:\workdir\go\src\runtime\cgo.go d:\workdir\go\src\runtime\cgocall.go d:\workdir\go\src\runtime\cgocallback.go d:\workdir\go\src\runtime\cgocheck.go d:\workdir\go\src\runtime\chan.go d:\workdir\go\src\runtime\compiler.go d:\workdir\go\src\runtime\complex.go d:\workdir\go\src\runtime\cpuflags.go d:\workdir\go\src\runtime\cpuprof.go d:\workdir\go\src\runtime\debug.go d:\workdir\go\src\runtime\env_posix.go d:\workdir\go\src\runtime\error.go d:\workdir\go\src\runtime\extern.go d:\workdir\go\src\runtime\fastlog2.go d:\workdir\go\src\runtime\fastlog2table.go d:\workdir\go\src\runtime\float.go d:\workdir\go\src\runtime\hash32.go d:\workdir\go\src\runtime\heapdump.go d:\workdir\go\src\runtime\iface.go d:\workdir\go\src\runtime\lfstack.go d:\workdir\go\src\runtime\lfstack_32bit.go d:\workdir\go\src\runtime\lock_sema.go d:\workdir\go\src\runtime\malloc.go d:\workdir\go\src\runtime\map.go d:\workdir\go\src\runtime\map_fast32.go d:\workdir\go\src\runtime\map_fast64.go d:\workdir\go\src\runtime\map_faststr.go d:\workdir\go\src\runtime\mbarrier.go d:\workdir\go\src\runtime\mbitmap.go d:\workdir\go\src\runtime\mcache.go d:\workdir\go\src\runtime\mcentral.go d:\workdir\go\src\runtime\mem_windows.go d:\workdir\go\src\runtime\mfinal.go d:\workdir\go\src\runtime\mfixalloc.go d:\workdir\go\src\runtime\mgc.go d:\workdir\go\src\runtime\mgclarge.go d:\workdir\go\src\runtime\mgcmark.go d:\workdir\go\src\runtime\mgcsweep.go d:\workdir\go\src\runtime\mgcsweepbuf.go d:\workdir\go\src\runtime\mgcwork.go d:\workdir\go\src\runtime\mheap.go d:\workdir\go\src\runtime\mprof.go d:\workdir\go\src\runtime\msan0.go d:\workdir\go\src\runtime\msize.go d:\workdir\go\src\runtime\mstats.go d:\workdir\go\src\runtime\mwbbuf.go d:\workdir\go\src\runtime\netpoll.go d:\workdir\go\src\runtime\netpoll_windows.go d:\workdir\go\src\runtime\os_nonopenbsd.go d:\workdir\go\src\runtime\os_windows.go d:\workdir\go\src\runtime\panic.go d:\workdir\go\src\runtime\plugin.go d:\workdir\go\src\runtime\print.go d:\workdir\go\src\runtime\proc.go d:\workdir\go\src\runtime\profbuf.go d:\workdir\go\src\runtime\proflabel.go d:\workdir\go\src\runtime\race0.go d:\workdir\go\src\runtime\rdebug.go d:\workdir\go\src\runtime\runtime.go d:\workdir\go\src\runtime\runtime1.go d:\workdir\go\src\runtime\runtime2.go d:\workdir\go\src\runtime\rwmutex.go d:\workdir\go\src\runtime\select.go d:\workdir\go\src\runtime\sema.go d:\workdir\go\src\runtime\signal_windows.go d:\workdir\go\src\runtime\sigqueue.go d:\workdir\go\src\runtime\sizeclasses.go d:\workdir\go\src\runtime\slice.go d:\workdir\go\src\runtime\softfloat64.go d:\workdir\go\src\runtime\stack.go d:\workdir\go\src\runtime\string.go d:\workdir\go\src\runtime\stubs.go d:\workdir\go\src\runtime\stubs32.go d:\workdir\go\src\runtime\stubs_arm.go d:\workdir\go\src\runtime\stubs_nonlinux.go d:\workdir\go\src\runtime\symtab.go d:\workdir\go\src\runtime\sys_arm.go d:\workdir\go\src\runtime\sys_nonppc64x.go d:\workdir\go\src\runtime\syscall_windows.go d:\workdir\go\src\runtime\time.go d:\workdir\go\src\runtime\timeasm.go d:\workdir\go\src\runtime\trace.go d:\workdir\go\src\runtime\traceback.go d:\workdir\go\src\runtime\type.go d:\workdir\go\src\runtime\typekind.go d:\workdir\go\src\runtime\unaligned2.go d:\workdir\go\src\runtime\utf8.go d:\workdir\go\src\runtime\vdso_in_none.go d:\workdir\go\src\runtime\vlrt.go d:\workdir\go\src\runtime\write_err.go d:\workdir\go\src\runtime\zcallback_windows.go: exit status 2
go tool dist: open C:\Data\SystemData\Temp\go-tool-dist-781085415\runtime_go_.a: The system cannot find the file specified.
The system cannot find the batch label specified - fail

I do not think there is anything to do here. Making remaining parts of windows-arm port will be tracked in #26148

Alex