-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/go: go mod tidy
always prints "finding" log messages
#27123
Comments
I had this issue with a message about I think there's something to do with indirect dependencies not providing packages at the chosen module version, but that's just a wild guess. |
|
As another example of an "unstable" https://gist.github.com/myitcv/65994e8083770e0a518c30cf815db47d The first gist file shows that The second gist file shows that What's interesting however is the contents of the
Given Buffalo is already a module, I would only have expected a single
(that said, the initial Perhaps the other contents of the |
Here's some more oddness demonstrated with the buffalo example. If I create a dumb wrapper package as follows:
Then:
This created a
Then I checked out github.com/gobuffalo/buffalo@v0.13.0 and went into that directory.
To take one example, the Further anomalies ensue:
but then no further entries for the dependencies of |
when we looked at something similar today it seems tidy is doing something similar to |
Our reproduction case was quite simple:
|
I'm trying to create a simple repo case as there may have been something else a play. |
@stevenh I'm not seeing that:
Do you have another dependency here which requires
give you? |
Ok here's a set of repo steps from a blank directory: mkdir wibble
cat <<EOT >wibble/test.go
package main
import (
"fmt"
"github.com/influxdata/influxdb/query"
)
func main() {
fmt.Println("go mod test")
}
EOT
go mod init
go get -u github.com/influxdata/influxdb@v1.3.9
grep influxdb go.mod
go get -u=patch
grep influxdb go.mod
go mod tidy
grep influxdb go.mod The final grep here will show: github.com/influxdata/influxdb v1.6.4 |
go mod graph | grep influx
github.com/multiplay/gomod github.com/influxdata/influxdb@v1.6.4
github.com/multiplay/gomod github.com/influxdata/influxql@v0.0.0-20180925231337-1cbfca8e56b6``` |
@stevenh that's happening because |
Interesting, so why doesn't the I'll keep playing as the original issue we had on our main repo which it at 1.4.0, Thanks for investigating that, most appreciated. |
@rogpeppe, can you still reproduce this? I notice that |
@bcmills Yes, I just tried with the latest release and it still happens.
|
I can't reproduce this from the |
Same for |
Same for |
After running
|
go version devel +4e1b11e2c9 Tue Aug 21 14:08:55 2018 +0000 linux/amd64
While I expect log messages the first time running a command, I don't expect them
to be printed the second time, after all information has already been found.
However in some cases,
go mod tidy
prints somefinding ... latest
messagesevery time it's run.
For example:
The text was updated successfully, but these errors were encountered: