-
-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHP7 Typehinting support #8
Comments
Hi, tanks for the suggestion.
What are your opinions? |
|
I agree for all your points.
I'm only worried for the works that needs to be done to port the code to use zend-code v3... |
In the last few days, I've had to modify this project to use zend-code 3.3 and generate classes with PHP7.1 parameter and return types for a project I'm working on. The amount of work to update this project to use zend-code v3 is quite little (see commit). I've sadly not yet had time to convert my changes into bite-sized pull requests. You might want to have a look at the commits to see whether any of the changes are interesting for this project, so I can perhaps extract them to PRs later on. |
For something like:
Makes sense to use php7 scalar typehints here. Could be hidden behind a flag in
config.yml
. I'll try to work on a PR if this sounds helpful?The text was updated successfully, but these errors were encountered: