-
-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update gdshader syntax #397
Update gdshader syntax #397
Conversation
I think it's pretty complete now. That reminds me, I should figure out adding |
Wait, we can do that? |
Yes, GitHub uses a public repository as a base for its syntax highlighting: https://github.com/github/linguist/blob/master/CONTRIBUTING.md |
I don't know if the purpose of that file is to be more like an "exhaustive" syntax test, but ...
I have already tested these things, so maybe my files are pointless, but, if you want, you can check one of my test files with things from the docs, to catch some you might be missing. Like I said before, I lost my other test file, which started here. There's also one with some variations of float literal syntax in this issue. If the purpose of the file is something else, just ignore what I said. |
Yeah, that's exactly what it is. All fantastic suggestions, thanks for the write-up. I'll have to study your test files a bit and come back to updating mine. @Calinou I'll expand the gdshader test file later, so this PR is ready as far as I'm concerned. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a ton!
Pull additional gdshader syntax improvements from @AlfishSoftware's work
The shader syntax looks good to me, but I'm currently trying to solicit feedback on the gdshader example file.