funcr: optimize WithValues/WithName/WithCallDepth

pohly · thockin · commit 4d2594003073 · 2022-12-03T08:45:47.000-08:00
All of these functions indirectly copied the entire Options struct because it
gets stored by value in the Formatter and thus fnlogger. The struct is
read-only, therefore sharing a single copy by pointer via different logger
instances is possible. Performance for the context value benchmark got better.
diff --git a/funcr/funcr.go b/funcr/funcr.go
@@ -218,7 +218,7 @@ func newFormatter(opts Options, outfmt outputFormat) Formatter {
 		prefix:       "",
 		values:       nil,
 		depth:        0,
-		opts:         opts,
+		opts:         &opts,
 	}
 	return f
 }
@@ -232,7 +232,7 @@ type Formatter struct {
 	values       []interface{}
 	valuesStr    string
 	depth        int
-	opts         Options
+	opts         *Options
 }
 
 // outputFormat indicates which outputFormat to use.

Original file line number	Diff line number	Diff line change
`@@ -218,7 +218,7 @@ func newFormatter(opts Options, outfmt outputFormat) Formatter {`
`218`	`218`	`prefix: "",`
`219`	`219`	`values: nil,`
`220`	`220`	`depth: 0,`
`221`		`- opts: opts,`
	`221`	`+ opts: &opts,`
`222`	`222`	`}`
`223`	`223`	`return f`
`224`	`224`	`}`
`@@ -232,7 +232,7 @@ type Formatter struct {`
`232`	`232`	`values []interface{}`
`233`	`233`	`valuesStr string`
`234`	`234`	`depth int`
`235`		`- opts Options`
	`235`	`+ opts *Options`
`236`	`236`	`}`
`237`	`237`
`238`	`238`	`// outputFormat indicates which outputFormat to use.`