Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Description Field for Secrets and Variables #33484

Open
John-jk opened this issue Feb 3, 2025 · 4 comments · May be fixed by #33526
Open

Add Description Field for Secrets and Variables #33484

John-jk opened this issue Feb 3, 2025 · 4 comments · May be fixed by #33526
Labels
proposal/accepted We have reviewed the proposal and agree that it should be implemented like that/at all. type/proposal The new feature has not been accepted yet but needs to be discussed first.

Comments

@John-jk
Copy link

John-jk commented Feb 3, 2025

Feature Description

Currently, Gitea does not provide a field for adding descriptions to secrets and variables in the repository settings. This makes it difficult for users to understand the purpose of a specific secret or variable, especially in larger projects with multiple contributors.
Thank you for considering this feature request!

Screenshots

No response
@John-jk John-jk added the type/proposal The new feature has not been accepted yet but needs to be discussed first. label Feb 3, 2025
@lunny lunny added the proposal/accepted We have reviewed the proposal and agree that it should be implemented like that/at all. label Feb 3, 2025
LaoQi added a commit to LaoQi/gitea that referenced this issue Feb 5, 2025
@LaoQi
Basic support description field for secrets and variables (go-gitea#3…
72ff170 
…3484)
@LaoQi
Copy link
Contributor

LaoQi commented Feb 6, 2025

I've added a basic description feature. For secrets, it works by replacing the ***** section and seems okay so far. But for variables, replacing the original values seems not well. Any other ideas?

Image

Image

@lunny
Copy link
Member

lunny commented Feb 6, 2025

Maybe always put 3 lines, secrets could put **** and variables put <value>.

@John-jk
Copy link
Author

John-jk commented Feb 6, 2025

How about this? If there is a description, the icon appears, if not, there is no icon. There will be fewer extra lines and they will all have the same height.

Image

@LaoQi
Copy link
Contributor

LaoQi commented Feb 6, 2025

I will try a 3 line layout first, using tips doesn't feel intuitive enough.

LaoQi added a commit to LaoQi/gitea that referenced this issue Feb 6, 2025
@LaoQi
Add migration for secrets and variables (go-gitea#33484)
bc8671b
LaoQi added a commit to LaoQi/gitea that referenced this issue Feb 6, 2025
@LaoQi
Basic support description field for secrets and variables (go-gitea#3…
aa0ca7e 
…3484)
LaoQi added a commit to LaoQi/gitea that referenced this issue Feb 6, 2025
@LaoQi
Add migration for secrets and variables (go-gitea#33484)
01dc6fa
LaoQi added a commit to LaoQi/gitea that referenced this issue Feb 6, 2025
@LaoQi
Basic support description field for secrets and variables (go-gitea#3…
2486df9 
…3484)
LaoQi added a commit to LaoQi/gitea that referenced this issue Feb 6, 2025
@LaoQi
Add migration for secrets and variables (go-gitea#33484)
7771ad9
@LaoQi LaoQi mentioned this issue Feb 6, 2025
Closed
LaoQi added a commit to LaoQi/gitea that referenced this issue Feb 6, 2025
@LaoQi
Basic support description field for secrets and variables (go-gitea#3…
fdf41bd 
…3484)
@LaoQi LaoQi linked a pull request Feb 6, 2025 that will close this issue
Open
LaoQi added a commit to LaoQi/gitea that referenced this issue Feb 9, 2025
@LaoQi
Basic support description field for secrets and variables (go-gitea#3…
ea77b65 
…3484)
LaoQi added a commit to LaoQi/gitea that referenced this issue Feb 9, 2025
@LaoQi
Basic support description field for secrets and variables (go-gitea#3…
6735dcd 
…3484)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
proposal/accepted We have reviewed the proposal and agree that it should be implemented like that/at all. type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added Description Field for Secrets and Variables LaoQi/gitea
3 participants
@lunny @LaoQi @John-jk