Skip to content

Commit 138e946

Browse files
silverwindsilverwind
authored
Replace gt-word-break with tw-break-anywhere (#31183)
`overflow-wrap: anywhere` is a superior alternative to `word-wrap: break-word` and we were already setting it in the class. I tested a few cases, all look good.
1 parent 9000811 commit 138e946

File tree

16 files changed

+18
-23
lines changed

16 files changed

+18
-23
lines changed

‎docs/content/contributing/guidelines-frontend.en-us.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ We recommend [Google HTML/CSS Style Guide](https://google.github.io/styleguide/h
4747
9. Avoid unnecessary `!important` in CSS, add comments to explain why it's necessary if it can't be avoided.
4848
10. Avoid mixing different events in one event listener, prefer to use individual event listeners for every event.
4949
11. Custom event names are recommended to use `ce-` prefix.
50-
12. Prefer using Tailwind CSS which is available via `tw-` prefix, e.g. `tw-relative`. Gitea's helper CSS classes use `gt-` prefix (`gt-word-break`), while Gitea's own private framework-level CSS classes use `g-` prefix (`g-modal-confirm`).
50+
12. Prefer using Tailwind CSS which is available via `tw-` prefix, e.g. `tw-relative`. Gitea's helper CSS classes use `gt-` prefix (`gt-ellipsis`), while Gitea's own private framework-level CSS classes use `g-` prefix (`g-modal-confirm`).
5151
13. Avoid inline scripts & styles as much as possible, it's recommended to put JS code into JS files and use CSS classes. If inline scripts & styles are unavoidable, explain the reason why it can't be avoided.
5252

5353
### Accessibility / ARIA

‎docs/content/contributing/guidelines-frontend.zh-cn.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ HTML 页面由[Go HTML Template](https://pkg.go.dev/html/template)渲染。
4747
9. 避免在 CSS 中使用不必要的`!important`，如果无法避免，添加注释解释为什么需要它。
4848
10. 避免在一个事件监听器中混合不同的事件，优先为每个事件使用独立的事件监听器。
4949
11. 推荐使用自定义事件名称前缀`ce-`。
50-
12. 建议使用 Tailwind CSS，它可以通过 `tw-` 前缀获得，例如 `tw-relative`. Gitea 自身的助手类 CSS 使用 `gt-` 前缀（`gt-word-break`），Gitea 自身的私有框架级 CSS 类使用 `g-` 前缀（`g-modal-confirm`）。
50+
12. 建议使用 Tailwind CSS，它可以通过 `tw-` 前缀获得，例如 `tw-relative`. Gitea 自身的助手类 CSS 使用 `gt-` 前缀（`gt-ellipsis`），Gitea 自身的私有框架级 CSS 类使用 `g-` 前缀（`g-modal-confirm`）。
5151
13. 尽量避免内联脚本和样式，建议将JS代码放入JS文件中并使用CSS类。如果内联脚本和样式不可避免，请解释无法避免的原因。
5252

5353
### 可访问性 / ARIA

‎templates/admin/repo/list.tmpl

+2-2
Original file line numberDiff line numberDiff line change
@@ -47,13 +47,13 @@
4747
<tr>
4848
<td>{{.ID}}</td>
4949
<td>
50-
<a class="gt-word-break" href="{{.Owner.HomeLink}}">{{.Owner.Name}}</a>
50+
<a class="tw-break-anywhere" href="{{.Owner.HomeLink}}">{{.Owner.Name}}</a>
5151
{{if .Owner.Visibility.IsPrivate}}
5252
<span class="text gold">{{svg "octicon-lock"}}</span>
5353
{{end}}
5454
</td>
5555
<td>
56-
<a class="gt-word-break" href="{{.Link}}">{{.Name}}</a>
56+
<a class="tw-break-anywhere" href="{{.Link}}">{{.Name}}</a>
5757
{{if .IsArchived}}
5858
<span class="ui basic label">{{ctx.Locale.Tr "repo.desc.archived"}}</span>
5959
{{end}}

‎templates/package/content/container.tmpl

+2-2
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@
5454
{{end}}
5555
{{if .PackageDescriptor.Metadata.ImageLayers}}
5656
<h4 class="ui top attached header">{{ctx.Locale.Tr "packages.container.layers"}}</h4>
57-
<div class="ui attached segment gt-word-break">
57+
<div class="ui attached segment tw-break-anywhere">
5858
<table class="ui very basic compact table">
5959
<tbody>
6060
{{range .PackageDescriptor.Metadata.ImageLayers}}
@@ -80,7 +80,7 @@
8080
{{range $key, $value := .PackageDescriptor.Metadata.Labels}}
8181
<tr>
8282
<td class="top aligned">{{$key}}</td>
83-
<td class="gt-word-break">{{$value}}</td>
83+
<td class="tw-break-anywhere">{{$value}}</td>
8484
</tr>
8585
{{end}}
8686
</tbody>

‎templates/package/settings.tmpl

+1-1
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@
5959
{{ctx.Locale.Tr "packages.settings.delete"}}
6060
</div>
6161
<div class="content">
62-
<div class="ui warning message gt-word-break">
62+
<div class="ui warning message tw-break-anywhere">
6363
{{ctx.Locale.Tr "packages.settings.delete.notice" .PackageDescriptor.Package.Name .PackageDescriptor.Version.Version}}
6464
</div>
6565
<form class="ui form" action="{{.Link}}" method="post">

‎templates/projects/view.tmpl

+1-1
Original file line numberDiff line numberDiff line change
@@ -152,7 +152,7 @@
152152
<div class="divider"{{if .Color}} style="color: {{ContrastColor .Color}} !important"{{end}}></div>
153153
<div class="ui cards" data-url="{{$.Link}}/{{.ID}}" data-project="{{$.Project.ID}}" data-board="{{.ID}}" id="board_{{.ID}}">
154154
{{range (index $.IssuesMap .ID)}}
155-
<div class="issue-card gt-word-break {{if $canWriteProject}}tw-cursor-grab{{end}}" data-issue="{{.ID}}">
155+
<div class="issue-card tw-break-anywhere {{if $canWriteProject}}tw-cursor-grab{{end}}" data-issue="{{.ID}}">
156156
{{template "repo/issue/card" (dict "Issue" . "Page" $)}}
157157
</div>
158158
{{end}}

‎templates/repo/home.tmpl

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
{{template "base/alert" .}}
66
{{template "repo/code/recently_pushed_new_branches" .}}
77
{{if and (not .HideRepoInfo) (not .IsBlame)}}
8-
<div class="repo-description gt-word-break">
8+
<div class="repo-description tw-break-anywhere">
99
{{- $description := .Repository.DescriptionHTML ctx -}}
1010
{{if $description}}{{$description | RenderCodeBlock}}{{end}}
1111
{{if .Repository.Website}}<a href="{{.Repository.Website}}">{{.Repository.Website}}</a>{{end}}

‎templates/repo/issue/list.tmpl

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
{{if .PinnedIssues}}
88
<div id="issue-pins" {{if .IsRepoAdmin}}data-is-repo-admin{{end}}>
99
{{range .PinnedIssues}}
10-
<div class="issue-card gt-word-break {{if $.IsRepoAdmin}}tw-cursor-grab{{end}}" data-move-url="{{$.Link}}/move_pin" data-issue-id="{{.ID}}">
10+
<div class="issue-card tw-break-anywhere {{if $.IsRepoAdmin}}tw-cursor-grab{{end}}" data-move-url="{{$.Link}}/move_pin" data-issue-id="{{.ID}}">
1111
{{template "repo/issue/card" (dict "Issue" . "Page" $ "isPinnedIssueCard" true)}}
1212
</div>
1313
{{end}}

‎templates/repo/issue/view_content/conversation.tmpl

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
<div class="ui segments conversation-holder">
99
<div class="ui segment collapsible-comment-box tw-py-2 tw-flex tw-items-center tw-justify-between">
1010
<div class="tw-flex tw-items-center">
11-
<a href="{{$comment.CodeCommentLink ctx}}" class="file-comment tw-ml-2 gt-word-break">{{$comment.TreePath}}</a>
11+
<a href="{{$comment.CodeCommentLink ctx}}" class="file-comment tw-ml-2 tw-break-anywhere">{{$comment.TreePath}}</a>
1212
{{if $invalid}}
1313
<span class="ui label basic small tw-ml-2" data-tooltip-content="{{ctx.Locale.Tr "repo.issues.review.outdated_description"}}">
1414
{{ctx.Locale.Tr "repo.issues.review.outdated"}}

‎templates/repo/release/list.tmpl

+1-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
</div>
1818
<div class="ui segment detail">
1919
<div class="tw-flex tw-items-center tw-justify-between tw-flex-wrap tw-mb-2">
20-
<h4 class="release-list-title gt-word-break">
20+
<h4 class="release-list-title tw-break-anywhere">
2121
{{if $.PageIsSingleTag}}{{$release.Title}}{{else}}<a class="muted" href="{{$.RepoLink}}/releases/tag/{{$release.TagName | PathEscapeSegments}}">{{$release.Title}}</a>{{end}}
2222
{{template "repo/commit_statuses" dict "Status" $info.CommitStatus "Statuses" $info.CommitStatuses "AdditionalClasses" "tw-flex"}}
2323
{{if $release.IsDraft}}

‎templates/repo/settings/options.tmpl

+1-1
Original file line numberDiff line numberDiff line change
@@ -217,7 +217,7 @@
217217
<tbody>
218218
{{range .PushMirrors}}
219219
<tr>
220-
<td class="gt-word-break">{{.RemoteAddress}}</td>
220+
<td class="tw-break-anywhere">{{.RemoteAddress}}</td>
221221
<td>{{ctx.Locale.Tr "repo.settings.mirror_settings.direction.push"}}</td>
222222
<td>{{if .LastUpdateUnix}}{{DateTime "full" .LastUpdateUnix}}{{else}}{{ctx.Locale.Tr "never"}}{{end}} {{if .LastError}}<div class="ui red label" data-tooltip-content="{{.LastError}}">{{ctx.Locale.Tr "error"}}</div>{{end}}</td>
223223
<td class="right aligned">

‎templates/repo/wiki/revision.tmpl

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
<div class="ui header">
99
<a class="file-revisions-btn ui basic button" title="{{ctx.Locale.Tr "repo.wiki.back_to_wiki"}}" href="{{.RepoLink}}/wiki/{{.PageURL}}"><span>{{.revision}}</span> {{svg "octicon-home"}}</a>
1010
{{$title}}
11-
<div class="ui sub header gt-word-break">
11+
<div class="ui sub header tw-break-anywhere">
1212
{{$timeSince := TimeSince .Author.When ctx.Locale}}
1313
{{ctx.Locale.Tr "repo.wiki.last_commit_info" .Author.Name $timeSince}}
1414
</div>

‎templates/shared/user/org_profile_avatar.tmpl

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
<div class="ui container">
33
<div class="ui vertically grid head">
44
<div class="column">
5-
<div class="ui header tw-flex tw-items-center gt-word-break">
5+
<div class="ui header tw-flex tw-items-center tw-break-anywhere">
66
{{ctx.AvatarUtils.Avatar . 100}}
77
<span class="text grey"><a class="muted" href="{{.HomeLink}}">{{.DisplayName}}</a></span>
88
<span class="org-visibility">

‎templates/shared/user/profile_big_avatar.tmpl

+2-2
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
</span>
1212
{{end}}
1313
</div>
14-
<div class="content gt-word-break profile-avatar-name">
14+
<div class="content tw-break-anywhere profile-avatar-name">
1515
{{if .ContextUser.FullName}}<span class="header text center">{{.ContextUser.FullName}}</span>{{end}}
1616
<span class="username text center">{{.ContextUser.Name}} {{if .IsAdmin}}
1717
<a class="muted" href="{{AppSubUrl}}/admin/users/{{.ContextUser.ID}}" data-tooltip-content="{{ctx.Locale.Tr "admin.users.details"}}">
@@ -25,7 +25,7 @@
2525
{{end}}
2626
</div>
2727
</div>
28-
<div class="extra content gt-word-break">
28+
<div class="extra content tw-break-anywhere">
2929
<ul>
3030
{{if .UserBlocking}}
3131
<li class="text red">{{svg "octicon-circle-slash"}} {{ctx.Locale.Tr "user.block.blocked"}}</li>

‎web_src/css/helpers.css

-5
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,6 @@ Gitea's tailwind-style CSS helper classes have `gt-` prefix.
33
Gitea's private styles use `g-` prefix.
44
*/
55

6-
.gt-word-break {
7-
word-wrap: break-word !important;
8-
overflow-wrap: anywhere;
9-
}
10-
116
.gt-ellipsis {
127
overflow: hidden !important;
138
white-space: nowrap !important;

‎web_src/js/features/repo-issue.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,7 @@ export function initRepoIssueSidebarList() {
125125
}
126126
filteredResponse.results.push({
127127
name: `<div class="gt-ellipsis">#${issue.number} ${htmlEscape(issue.title)}</div>
128-
<div class="text small gt-word-break">${htmlEscape(issue.repository.full_name)}</div>`,
128+
<div class="text small tw-break-anywhere">${htmlEscape(issue.repository.full_name)}</div>`,
129129
value: issue.id,
130130
});
131131
});

0 commit comments

Comments
 (0)