-
Notifications
You must be signed in to change notification settings - Fork 54
Skip deleted package files in CI. #560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I am deploying the workflow on my local repository to test this. Will report back |
Yep!! It works properly. |
I didn't test this much apart from feeding some input into that bash snippet locally. I'd prefer if @siko1056 could have a look, too. There's also no rush for this. So, imho we could keep this open for a week or so. |
Ok. Let's wait for @siko1056 's input as well. I did test it on a deployed version in my personal GitHub account and it seems to work (after pushing a commit to remove a yaml file, after a few refreshes, the Package Index wasn't listing the removed package, but I am not 100% confident about what the functionality should/would look like. I am not sure, whether merging a PR behaves differently, because on the actual deployment (this repo) we cannot push a commit, it has to be pulled as a PR. So let's wait a bit. |
Thank you for this PR, I will try it later this week. |
Works like a charm @mmuetzel . Please merge 🙏 I made a local test commit that removes two packages, changes two packages and adds one package. It detects it all and would run the checks on the modified and new package only 👍
|
Thank you both for the review. |
Fixes #545.