Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add XML document builder and eventifier with scala-xml implementation #328

Merged
merged 6 commits into from
Jun 9, 2022
Merged

Add XML document builder and eventifier with scala-xml implementation #328

merged 6 commits into from
Jun 9, 2022

Conversation

satabin
Copy link
Member

@satabin satabin commented Jun 5, 2022 •
edited
Loading

  • Add tree builder abstraction
  • Add tree envitifer abstraction
  • Add scala-xml tree builder implementation
  • Add scala-xml tree eventifier implementation
  • update documentation

Closes #56.

@satabin satabin added enhancement New feature or request xml labels Jun 5, 2022
@satabin satabin added this to the 1.4.0 milestone Jun 5, 2022
@satabin satabin marked this pull request as draft June 5, 2022 15:26
@satabin satabin force-pushed the xml/tree-builder branch 5 times, most recently from dfb71f5 to b931eaf Compare June 5, 2022 19:06
@satabin satabin force-pushed the xml/tree-builder branch from b931eaf to 19b3ba9 Compare June 5, 2022 19:11
@satabin
Copy link
Member Author

satabin commented Jun 5, 2022

Poke @Korbik

@satabin satabin force-pushed the xml/tree-builder branch from 958311b to 19b3ba9 Compare June 5, 2022 20:37
@satabin satabin marked this pull request as ready for review June 6, 2022 15:49
@satabin satabin requested a review from ybasket June 6, 2022 15:49
@satabin satabin changed the title Add XML tree builder and eventifier with scala-xml implementation Add XML document builder and eventifier with scala-xml implementation Jun 7, 2022
@satabin satabin force-pushed the xml/tree-builder branch 3 times, most recently from ed243e5 to 19037e9 Compare June 8, 2022 11:38
satabin added 5 commits June 8, 2022 17:21
@satabin satabin force-pushed the xml/tree-builder branch from 19037e9 to e7f0856 Compare June 8, 2022 15:28
@satabin satabin requested a review from ybasket June 9, 2022 11:55
ybasket
ybasket approved these changes Jun 9, 2022
View reviewed changes
Copy link
Collaborator

@ybasket ybasket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)

@satabin satabin merged commit a805e80 into main Jun 9, 2022
@satabin satabin deleted the xml/tree-builder branch June 9, 2022 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ybasket ybasket ybasket approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request xml
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.

Add Builder and Tokenizer for XML
2 participants
@satabin @ybasket