Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beginless Ranges are not supported in ruby '<2.7' #254

Closed
kyntk opened this issue Nov 17, 2022 · 3 comments
Closed

Beginless Ranges are not supported in ruby '<2.7' #254

kyntk opened this issue Nov 17, 2022 · 3 comments

Comments

@kyntk
Copy link

kyntk commented Nov 17, 2022

  • ruby version: 2.6.10
  • version: gemoji 4.0.0

An error was caused by that beginless ranges are not supported in ruby '<2.7'.
Is ruby 2.6 or lower no longer supported?

gemoji-4.0.0/lib/emoji/character.rb:54: syntax error, unexpected ..., expecting ']'
            raw_normalized[...idx] + modifier + raw_normali...
                           ^~~
@mislav
Copy link
Contributor

mislav commented Nov 18, 2022

We stopped testing in Ruby 2.6 due to it being EOL (end-of-life). However, it wasn't intentional to introduce a change that is only supported from Ruby 2.7. You are welcome to submit a PR that adds 0 as the beginning to the range!

@perlun
Copy link
Contributor

perlun commented Nov 22, 2022

@mislav @kyntk I gave it a try since I saw this also in my own CI runs (perlun/perlun.eu.org#39). Here's my attempt at a PR: #255

@mislav
Copy link
Contributor

mislav commented Nov 22, 2022

Thank you! Fixed in 33caddc

@mislav mislav closed this as completed Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants