Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding previous and next links for moving between articles #146

Closed
zeke opened this issue Nov 12, 2019 · 9 comments
Closed

Adding previous and next links for moving between articles #146

zeke opened this issue Nov 12, 2019 · 9 comments
Labels
engineering Will involve Docs Engineering

Comments

@zeke
Copy link
Contributor

zeke commented Nov 12, 2019

In https://github.com/github/help-docs/pull/11410 we introduced breadcrumbs. Under the hood, the breadcrumbs are generated by a currentTree object that captures the entire hierarchy of the site, relative to the page you're currently viewing. We can use this new tree to infer what pages precede and follow a given article.

Let's consider adding [Previous] and [Next] links below each article, where appropriate. We'll have to iron out the details of when these links should and should NOT be displayed:

  • should these links be displayed for articles that don't have a parent map topic?
  • does an article at the end of a map topic link to the next map topic?
  • does an article at the beginning of a map topic link to the previous map topic?
  • does an article at the end of the last map topic have a [next] link?
  • etc

cc @github/product-docs-engineering @github/product-docs-content-strategy

@emilyistoofunky
Copy link
Member

Let's consider adding [Previous] and [Next] links below each article, where appropriate.

🙌 ⚡️

should these links be displayed for articles that don't have a parent map topic?

👍 Yes, I think so! Some categories don't have map topics and the previous and next buttons would still be useful as we still display the content in a somewhat linear order.

The only category without map topics where the buttons might not make as much sense is probably in the "Site policy" category, although I don't think it will hurt anything to have them displayed there.

does an article at the end of a map topic link to the next map topic?
does an article at the beginning of a map topic link to the previous map topic?

Great questions - I think so! 👍

does an article at the end of the last map topic have a [next] link?

In this case, I think not, since the next link would go to the next category and those aren't as closely linked as map topics within a category. Also, the next category will be shown in the sidebar.

@github-actions
Copy link
Contributor

This issue is stale because it has been open 60 days with no activity. Comment with a status update or this will be closed in 14 days

@zeke
Copy link
Contributor Author

zeke commented Jul 25, 2020

Still relevant.

@jwargo
Copy link
Contributor

jwargo commented Jul 28, 2020

@sezhan1229 Can you help us out with a design for this? We'll need to have that ready when we begin implementation on this.

@zeke zeke transferred this issue from another repository Oct 6, 2020
@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Oct 6, 2020
@zeke zeke added engineering Will involve Docs Engineering and removed triage Do not begin working on this issue until triaged by the team labels Oct 6, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2020

This issue is stale because it has been open 60 days with no activity.

@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Dec 6, 2020
@janiceilene janiceilene removed the stale There is no recent activity on this issue or pull request label Dec 7, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2021

This issue is stale because it has been open 60 days with no activity.

@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Feb 6, 2021
@emilyistoofunky emilyistoofunky removed the stale There is no recent activity on this issue or pull request label Feb 8, 2021
@janiceilene
Copy link
Contributor

@chiedo @emilyistoofunky Is this still relevant or should we close it out?

@emilyistoofunky
Copy link
Member

I think this may be part of the learning track designs - @chiedo do you know?

@chiedo
Copy link
Contributor

chiedo commented Feb 8, 2021

Yeah we can close this one out! We've got it tracked elsewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engineering Will involve Docs Engineering
Projects
None yet
Development

No branches or pull requests

5 participants