0/Test Donation model #9391
Merged
0/Test Donation model #9391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremyschuurmans
requested review from
chibie,
frankchen07,
gdixon,
octavioamu,
PixelantDesign,
thelostone-mc and
zlsgh
as code owners
jeremyschuurmans
changed the base branch from
add-grants-unit-tests
to
master
thelostone-mc
approved these changes
Sep 17, 2021
| name='end_date', | ||
| field=models.DateTimeField(default=grants.models.match_pledge.next_month), | ||
| ), | ||
| ] |
There was a problem hiding this comment.
How does this help?
t seems like we are adding the same operation again
There was a problem hiding this comment.
@thelostone-mc You're right, this doesn't help the Donation tests at all 🙂 This is from #9483 - the integration branch for this PR that this was branched off of which is still waiting to be merged.
The issue this resolves is that with the grants models in their own files rather than one file, next_month needs to be accessed by calling grants.models.match_pledge.next_month rather than grants.models.next_month. I didn't want to directly edit a migration that was already run in production, so I added the change as a try/except.
jeremyschuurmans
changed the base branch from
master
to
add-grants-unit-tests
jeremyschuurmans
changed the base branch from
add-grants-unit-tests
to
master
jeremyschuurmans
changed the base branch from
master
to
add-grants-unit-tests
jeremyschuurmans
force-pushed
the
test-donation
branch
from
fc10e49 to
f1e3da2
Compare
jeremyschuurmans
force-pushed
the
add-grants-unit-tests
branch
2 times, most recently
from
69bb98a to
81f1318
Compare
jeremyschuurmans
changed the base branch from
add-grants-unit-tests
to
master
added 5 commits
September 27, 2021 15:15
* create new directory for models, copy over Contribution model * extract grants models to individual files * rename relocated_models directory, remove original models directory, add imports, resolve circular dependencies * extract CLRMatch into separate file * extract Flag into separate file * extract MatchPledge to separate file * extract Donation and PhantomFunding * extract GrantStat into separate file * refactor * extract GrantBrandingRoutingPolicy to separate file * update migration * add missing import to MatchPledge, remove imports from __init__.py * add missing import * decouple GrantCLRCalculation and move to own file * extract GrantType to own file * extract GrantCLR to own file * add missing import * refactor, add missing imports * remove whitespace * resolve circular dependency * run 'make fix' * import changes from gitcoinco#9314 * add try/except to migration file instead of editing migration directly * refactor
added 14 commits
September 27, 2021 15:15
jeremyschuurmans
force-pushed
the
test-donation
branch
from
f1e3da2 to
cbbfae3
Compare
ksolo
approved these changes
Sep 28, 2021
thelostone-mc
approved these changes
Sep 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds unit tests to the Donation model
Refers/Fixes
Testing