Start improving missing contribution page #8546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mds1
requested review from
chibie,
frankchen07,
gdixon,
octavioamu,
PixelantDesign and
thelostone-mc
as code owners
owocki
reviewed
Mar 11, 2021
app/grants/views.py
Outdated
| network = request.POST.get('network') | ||
| ingestion_types = [] # after each series of ingestion, we append the ingestion_method to this array | ||
|
|
||
| # Setup web3 | ||
| PROVIDER = f"wss://{network}.infura.io/ws/v3/{settings.INFURA_V3_PROJECT_ID}" | ||
| w3 = Web3(Web3.WebsocketProvider(PROVIDER)) |
There was a problem hiding this comment.
Just pushed commit 9847312 to update this if you want to retest > merge > deploy
|
just tested on my local, works gr8. |
owocki
approved these changes
Mar 11, 2021
|
@thelostone-mc any comments on this one? |
thelostone-mc
approved these changes
Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this should work, but before merging needs more testing first against a mainnet token list. The reason is because web3py does not let you recover addresses from PoA networks like Rinkeby and it throws with:
web3.exceptions.ValidationError: The field extraData is 97 bytes, but should be 32. It is quite likely that you are connected to a POA chain. Refer http://web3py.readthedocs.io/en/stable/middleware.html#geth-style-proof-of-authority for more details. The full extraData is: HexBytes('0xd883010918846765746888676f312e31352e35856c696e757800000000000000c4f6ccfbbfd37487321a523acfb0d11475512cb299470d2991199c781e5594e80349e828106f55eb2f2a7734b377050624ea517aba9f55178d9fcd1165d9f31000')So to verify this works: