Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abdul/fix/grant new tab #7805

Merged
merged 8 commits into from
Nov 9, 2020
Merged

Abdul/fix/grant new tab #7805

merged 8 commits into from
Nov 9, 2020

Conversation

aamustapha-gitcoin
Copy link
Contributor

@aamustapha-gitcoin aamustapha-gitcoin commented Nov 2, 2020

Description

When a user accidentally clicks on a grant, it overrides all filters and pagination data which can be quite a headache to go back and apply filters and scroll. A quick solution is to open grants in new tab.

Refers/Fixes

refers #7802

Testing

@codecov
Copy link

codecov bot commented Nov 2, 2020

Codecov Report

Merging #7805 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7805   +/-   ##
=======================================
  Coverage   25.36%   25.36%           
=======================================
  Files         328      328           
  Lines       33082    33082           
  Branches     4926     4926           
=======================================
  Hits         8391     8391           
+ Misses      24408    24403    -5     
- Partials      283      288    +5     
Impacted Files Coverage Δ
app/quests/views.py 14.91% <0.00%> (ø)
app/dashboard/views.py 10.31% <0.00%> (ø)
...rketing/management/commands/no_applicants_email.py 0.00% <0.00%> (ø)
...eting/management/commands/assemble_leaderboards.py 39.73% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3b1ab7...d01836a. Read the comment docs.

@danlipert
Copy link
Contributor

@aamustapha-gitcoin make sure to fill out the PR form completely when you post a PR. The description should describe what this PR is changing and why we are changing it. The Refers is a place to link the issue, ticket, comment, or other PR that relates to this one, and the testing section should describe how you tested it (or whether you tested it), so some comment like "untested" "tested locally by creating a new grant" "see unit tests" etc. Also, please post a screen share video of the changes or at least screenshots.

@thelostone-mc thelostone-mc merged commit 9056420 into master Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants