-
-
Notifications
You must be signed in to change notification settings - Fork 776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix NoReverseMatch when project_name is empty #7773
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Just one little typo, but looks great
Codecov Report
@@ Coverage Diff @@
## master #7773 +/- ##
=======================================
Coverage 25.42% 25.42%
=======================================
Files 328 328
Lines 33044 33044
Branches 4918 4919 +1
=======================================
Hits 8401 8401
+ Misses 24356 24351 -5
- Partials 287 292 +5
Continue to review full report at Codecov.
|
Description
Currently, when a project name is empty the reverse url method raises a NoReverseMatch error. This can prevent customers from temporarily being able to access the system. A quickfix could be to modify defaulting instances but a more longterm solution would be to allow null project_name. This is done by
Refers/Fixes
Testing