Load all grants based on current filters into the cart #7371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Integrate minimal working ETH-only zkSync checkout * Refactor L1 checkout a bit to enable more code re-use with zkSync * Adds full working checkout flow using localstorage, supports ERC20 + ETH * Improve checkout UX by adding modal whehn using zkSync * Warn user before closing or reloading if they started zkSync checkout * Switch to deterministic from ephemeral wallet, fix allowance bug Allowance bug info: If user already had sufficient allowance, tokens were not transferred * Pull out logic into functions to facilitate re-sending on interrupted deposits * zkSync checkout now POSTs to database and shows success message on completion * Handle zkSync checkout interruptions * Fix ESLint errors, add some try/catch blocks * Fix bug in tx validator that prevented testing on rinkeby Also some prep and cleanup for tx validator update * Update tx validator to handle zkSync transfers * Tweak: Show metamask popup on zkSync checkout prompts * Only allow zkSync modal to be closed with a button to prevent accidental closures when checking out * zkSync checkout can now be resumed if interrupted Adds endpoint to look for dropped and replaced transactions to help with this * Various UI/UX updates based on Figma mockups - Update tx processing section of zkSync checkout modal - Update grant detauls page to show Etherscan and zkScan links - Add note about supported L2 account types on new grant page * Update address of batch deposit contract * Reduce gas by only using batch deposit contract when necessary, regular zkSync contract otherwise * Now throws error if user tries to use zkSync checkout with unsupported token
* add list view for grants and migrate to vue * hide idle grants by default * Add contributions on grants * add my grants * Minor fix * Implement follow in vuejs * remove duplicated ids Co-authored-by: Aditya Anand M C <aditya.anandmc@gmail.com>
* Checks and validates cart amounts to ensure they are packable * Add support for additional deposits. After donations are complete, all leftover balances are sent to user's web3 address * Update appearance of zkSync modal to match new designs * Add additional checkout flow to support users who already have a zkSync balance * Update detail.js Co-authored-by: Aditya Anand M C <aditya.anandmc@gmail.com>
…ound-7-integration
…ound-7-integration
* Show SMS on trust bonus page w/ conditional verify button or status * Add placeholder for twitter verification & handle SMS verification via cart link * Conditionally show Trust Bonus banner in cart * Include link in cart trust bonus button + bonus screen touchups * Increase the size of the BrightID QR Code * Fix linting indentation error
Codecov Report
@@ Coverage Diff @@
## round-7-integration #7371 +/- ##
=======================================================
+ Coverage 26.29% 26.31% +0.02%
=======================================================
Files 306 306
Lines 30390 30350 -40
Branches 4487 4481 -6
=======================================================
- Hits 7992 7988 -4
+ Misses 22128 22092 -36
Partials 270 270
Continue to review full report at Codecov.
|
|
ooooh im excite about this functionality |
owocki
reviewed
Sep 14, 2020
| base_params['idle'] = this.idle_grants; | ||
| } | ||
|
|
||
| if (this.show_contributions) { |
There was a problem hiding this comment.
is there a way to DRY this so that if we add a new filter on the left side, it doesnt break the add all to cart functionality?
There was a problem hiding this comment.
I think in some other opportunity we should dry the filters in general then we can reuse it here
|
left 1 comment; curiou swhat @thelostone-mc thinks tho |
* Fix zkScan URLs * Ensure default network is mainnet * Impove how tokens are fetched, close zksync modal on 'insufficient balance' errors * Bug fix: prevents users from checking out when donation amounts + fees exceed their L1 wallet balance
* Add gas estimation for approval txs * Fixes for Argent and BN, CSS tweak for mobile
…ound-7-integration
|
is duplicating grants maybe because is mixing numbers with strings |
|
seems no_report is not used |
* Add twitter verification for grants * Update logic to display grant verified badge * Fixes based on feedback * Update security fro verify grants * Fix attribute error * Remove twitter sdk
|
turning into draft, @zoek1 let us know when conflicts get fixed |
|
@octavioamu this was included in #7446 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refers/Fixes
#7164
Testing