Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

if a GTC distribution does not exist, then user should not be able to go https://gitcoin.co/quadraticlands/mission/receive #8948

Closed
owocki opened this issue May 25, 2021 · 1 comment

Comments

@owocki
Copy link
Contributor

owocki commented May 25, 2021

https://gitcoin.co/quadraticlands/mission/receive

go here without a claim

you can go through the flow

expect results:

  1. you cannot go through the flow or if you can it should give you an error at the top of proof of use before it hits the ESMS
scco added a commit to scco/gitcoin-web that referenced this issue May 26, 2021
@scco scco mentioned this issue May 26, 2021
@gdixon gdixon closed this as completed in 030065c May 26, 2021
thelostone-mc added a commit that referenced this issue Jul 12, 2021
…rd/Owocki Code) (#9039)

* zeroclaim-interface-fix #8948

- in progress

* zeroclaim-interface-fix

- added a view in claim.html that tell users they have 0 tokens + give them the option to complete the mission by forward to outro.

- added a hidden div that forward claimable token amount via data-atribute to js world

- added a check in claim.js for token amount = 0 to update the claim view on load

* fix linter

* initial works on diplomacy mission

- index / room template
- artworks
- embed in /missions

* updated diplomacy svgs

* quadratic diplomacy interface

- room list ( index page ) v1 done
- room detail - todo

* fix lintings

* minor fixes

* quadratic diplomacy interface

* adding some basic js for vouche validation WIP

* create room css fix

* Update diplomacy-create-room.scss

* read wallet / do calculations for the voucheBar

* add readonly on "self members"

* links + header sizzle

* dat model tho

* WIP

* WIP

* testing

* almost there

* update diplomacy frontend

- updated hero
- some js changes so the hero is animated
- changed a bit the dom for .tokens to have .in and .out + details per member

* some particle love

* toggle-able member cards that have options for detailed in out data

* sign atures saved

* works

* it works

* invite links

* navgation fix

no-wallet button was not working anymore. so heres a fix

* fix section in section for chat-message-box kev invented

* add mergr migration

* edits player handle

* small  fix

* refs

* small fix

* notification for diplomacy

* some more interface tweaks

based on what i can see here in my fork ( not sure if i am behind with whats going on on staging - here are some tweaks )  goals :

definitly remove scroll bars on chat pls!

* room joining

* merge fixes and basic playtest

* add better scroll

* fixes migrations and refreshing

* some improvements see description

- outsourced hero animation to own file
- fixed bug on intersection observer for arrow navigation
- removed particle animation on delete room
- fixed "your games" headline in index

* wip verification - need adityas help to get it to work

* avoid using reserved name

* #9039 (comment)

* precompute data

* a few small things

* qd

* amount

* it works thx aditya

* copy

* gs

* lint fixes

* remove default

* un-needed migrations

* recreate migrations

* wip: profile trust tab

* Adds options to have a disabled/an alternative "disconnect" button on verified service

* hide behind staff

Co-authored-by: scco <schumanncombo@gmail.com>
Co-authored-by: Aditya Anand M C <aditya.anandmc@gmail.com>
Co-authored-by: Kevin Owocki <owocki@Kevins-MacBook-Pro.local>
Co-authored-by: root <root@ip-172-31-15-65.us-west-2.compute.internal>
Co-authored-by: Graham Dixon <graham@gdixon.co.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@owocki @frankchen07 and others