ggml-metal: round up to 16 to fix setThreadgroupMemoryLength assertion #3938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psugihara
changed the title
ggerganov
approved these changes
Nov 3, 2023
ggerganov
reviewed
Nov 3, 2023
| @@ -1348,7 +1348,7 @@ void ggml_metal_graph_compute( | |||
| [encoder setBytes:&ne00 length:sizeof( int64_t) atIndex:2]; | |||
| [encoder setBytes:&nb01 length:sizeof(uint64_t) atIndex:3]; | |||
| [encoder setBytes:&eps length:sizeof( float) atIndex:4]; | |||
| [encoder setThreadgroupMemoryLength:nth*sizeof(float) atIndex:0]; | |||
| [encoder setThreadgroupMemoryLength:MAX(16, nth*sizeof(float)) atIndex:0]; | |||
There was a problem hiding this comment.
This could still fail the check when ne00 < 256 && ne00 % 4 != 0
|
are the same changes applicable to https://github.com/ggerganov/llama.cpp/pull/3938/files#diff-d189c5117255f368aa89f521bd523afa399ada0bbfb7043b74c65bf4ac2472fdR1332? |
brittlewis12
added a commit
to brittlewis12/llmfarm_core.swift
that referenced
this pull request
Nov 17, 2023
brittlewis12
added a commit
to brittlewis12/llmfarm_core.swift
that referenced
this pull request
Nov 18, 2023
olexiyb
pushed a commit
to Sanctum-AI/llama.cpp
that referenced
this pull request
Nov 23, 2023
brittlewis12
added a commit
to brittlewis12/llmfarm_core.swift
that referenced
this pull request
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this fix, when running inside Xcode, MTLDebugComputeCommandEncoder throws the following assertion:
-[MTLDebugComputeCommandEncoder setThreadgroupMemoryLength:atIndex:]:817: failed assertion `length(4) must be a multiple of 16 bytes.'Logging shows me it’s getting passed 4 on line 1020. This fix just makes sure that we round up to 16 if we’re under.
Here’s the relevant doc that discusses setThreadgroupMemoryLength being a multiple of 16: https://developer.apple.com/documentation/metal/mtlcomputecommandencoder/1443142-setthreadgroupmemorylength