Tags not set if many resources in SLS / CloudFormation stack

[Ilnore]

If an SLS / CloudFormation stack has many resources (more than 100), this plugin will not reliably set CloudWatch log group tags.

The root cause is this:

serverless-tag-cloud-watch-logs/index.js

Lines 48 to 55 in 8fae6c0

	getStackResources() {
	return new Promise((resolve, reject) => {
	this.cloudWatchLogsService.describeStackResources({ StackName: this.stackName }, (err, data) => {
	if (err) return reject(err);
	resolve(data);
	});
	});
	}

Quoting the AWS SDK documentation for CloudFormation.describeStackResources:

Note: Only the first 100 resources will be returned. If your stack has more resources than this, you should use ListStackResources instead.

So only the first 100 resources in a stack get considered for tagging. If the stack has more than 100 resources, it's pretty much random if the log groups are returned within the first 100, and if they are returned, then they will get the tags, and if they do not fit into the 100, then they're ignored and no tags are set.

Proposed solution:

As hinted by CloudFormation.describeStackResources documentation, we should use CloudFormation.listStackResources here instead.

[Ilnore]

Looks like this has been fixed in a fork of this repo, which is served in NPM as serverless-tag-cloud-watch-log-groups.

https://github.com/randomhash/serverless-tag-cloud-watch-logs/blob/59dac5860a9ca2e8d3db9c9bd223ba55b8101c46/index.js#L66-L76