-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(test): Disable Vitest globals #15507
Conversation
@@ -1,4 +1,6 @@ | |||
import sentryAstro from '../../src/index.server'; | |||
import { describe, expect, it } from 'vitest'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's make the vitest
import the first import on the file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I thought linting would sort this all out!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, this is because since Biome was added, import order has not been enforced. I looked to get this working again and it impacts hundreds of files
❌ 196 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
577e6f3
to
b21ecb6
Compare
We should not use Vitest globals except where they are required.
This PR:
globals
in our rootvite.config.ts
globals: true
for React since there are load of test failures without it and I couldn't immedialy work out why