From 5213b524b44fd13e4099405074035fff59a32088 Mon Sep 17 00:00:00 2001 From: Ran Byron Date: Thu, 31 Oct 2019 08:41:05 +0200 Subject: [PATCH] Sorting param names in error msgs --- redash/models/parameterized_query.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/redash/models/parameterized_query.py b/redash/models/parameterized_query.py index d519836318..64c4b5d482 100644 --- a/redash/models/parameterized_query.py +++ b/redash/models/parameterized_query.py @@ -225,7 +225,7 @@ def missing_params_error(self): if not missing_params: return None - parameter_names = ', '.join('"{}"'.format(name) for name in missing_params) + parameter_names = ', '.join('"{}"'.format(name) for name in sorted(missing_params)) if len(missing_params) > 1: message = 'Parameters {} are missing.'.format(parameter_names) else: @@ -241,7 +241,7 @@ def text(self): class InvalidParameterError(Exception): def __init__(self, parameter_errors): - parameter_names = ', '.join('"{}"'.format(name) for name in parameter_errors.keys()) + parameter_names = ', '.join('"{}"'.format(name) for name in sorted(parameter_errors.keys())) if len(parameter_errors) > 1: message = 'Parameters {} are invalid.'.format(parameter_names) else: