Sorting param names in error msgs

getredash · Oct 31, 2019 · 5213b52 · 5213b52
1 parent e20b2b5
commit 5213b52
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/redash/models/parameterized_query.py b/redash/models/parameterized_query.py
@@ -225,7 +225,7 @@ def missing_params_error(self):
         if not missing_params:
             return None
 
-        parameter_names = ', '.join('"{}"'.format(name) for name in missing_params)
+        parameter_names = ', '.join('"{}"'.format(name) for name in sorted(missing_params))
         if len(missing_params) > 1:
             message = 'Parameters {} are missing.'.format(parameter_names)
         else:
@@ -241,7 +241,7 @@ def text(self):
 
 class InvalidParameterError(Exception):
     def __init__(self, parameter_errors):
-        parameter_names = ', '.join('"{}"'.format(name) for name in parameter_errors.keys())
+        parameter_names = ', '.join('"{}"'.format(name) for name in sorted(parameter_errors.keys()))
         if len(parameter_errors) > 1:
             message = 'Parameters {} are invalid.'.format(parameter_names)
         else: