Windows SetTooltip invalid memory address

[psidex]

PS C:\Users\Simon\go\src\github.com\psidex\EACS> go run .\cmd\test\main.go
panic: runtime error: invalid memory address or nil pointer dereference
[signal 0xc0000005 code=0x0 addr=0x0 pc=0x6608e6]

goroutine 6 [running]:
github.com/getlantern/systray.(*winTray).setTooltip(0x921fa0, 0x6f6138, 0x1d, 0xc000086058, 0xc0000311b8)
        C:/Users/Simon/go/pkg/mod/github.com/getlantern/systray@v1.0.3/systray_windows.go:226 +0x66
github.com/getlantern/systray.SetTooltip(0x6f6138, 0x1d)
        C:/Users/Simon/go/pkg/mod/github.com/getlantern/systray@v1.0.3/systray_windows.go:852 +0x4c
main.OnReady()
        C:/Users/Simon/go/src/github.com/psidex/EACS/cmd/test/main.go:8 +0x3d
github.com/getlantern/systray.Register.func2(0xc000014180, 0x706528)
        C:/Users/Simon/go/pkg/mod/github.com/getlantern/systray@v1.0.3/systray.go:91 +0x45
created by github.com/getlantern/systray.Register
        C:/Users/Simon/go/pkg/mod/github.com/getlantern/systray@v1.0.3/systray.go:89 +0xe3
exit status 2

here is the contents of main.go:

package main

import (
	"github.com/getlantern/systray"
)

func OnReady() {
	systray.SetTooltip("This is the tooltip text")
}

func OnExit() {
	// No cleanup needed.
}

func main() {
	systray.Run(OnReady, OnExit)
}

[ldstein]

FWIW, I'm also experiencing this issue.

I'm observing if I run the compiled exe 6-7 times, ~30% will fail with the above mentioned error.

v0.9.0 doesn't appear to be affected. 1.0.0, 1.0.1, 1.0.2 and 1.0.3 exhibit this issue.

Tested with:

• Windows 10 x64
• Go 1.14.1
• TDC-GCC 5.1.0-2 and TDM-GCC 9.2.0

Edit - This appears to fix the issue - just need to ensure systray.SetIcon() is run before systray.SetTooltip().

[ldstein]

Can't comment on v1.0.4 specifically, but have been giving 4c7e35b4e5114211b7c7c3b57484c56de802767a a good workout for the last couple of days. Fixed all the issues for me (only tested on Windows).

[psidex]

I'm still experiencing the same error on 1.0.4 (using the same code in my initial issue):

PS C:\Users\Simon\go\src\github.com\psidex\trayTest> go run .\main.go
panic: runtime error: invalid memory address or nil pointer dereference
[signal 0xc0000005 code=0x0 addr=0x0 pc=0x6608ae]

goroutine 6 [running]:
github.com/getlantern/systray.(*winTray).setTooltip(0x923260, 0x6f5060, 0x18, 0x0, 0x0)
        C:/Users/Simon/go/pkg/mod/github.com/getlantern/systray@v1.0.4/systray_windows.go:238 +0xce
github.com/getlantern/systray.SetTooltip(0x6f5060, 0x18)
        C:/Users/Simon/go/pkg/mod/github.com/getlantern/systray@v1.0.4/systray_windows.go:899 +0x4c
main.OnReady()
        C:/Users/Simon/go/src/github.com/psidex/trayTest/main.go:8 +0x3d
github.com/getlantern/systray.Register.func2(0xc000014180, 0x7075d0)
        C:/Users/Simon/go/pkg/mod/github.com/getlantern/systray@v1.0.4/systray.go:91 +0x45
created by github.com/getlantern/systray.Register
        C:/Users/Simon/go/pkg/mod/github.com/getlantern/systray@v1.0.4/systray.go:89 +0xe3
exit status 2

But I can confirm that setting the icon before setting the tooltip does work.

[psidex]

I am also getting an Invalid menu handle error when using AddMenuItem before using SetIcon.

All of these issues seem to be linked to something that SetIcon does?

It all works if the first thing I do is call SetIcon, but trying to use any other method before that (such as AddMenuItem or SetTooltip) causes errors

[Etua]

My program would crash about 50% of the time because of this issue until I started adding 500ms delay before calling setToolTip as suggested by @ldstein in #164 and it seems to have worked. Why you ask? I have no idea but there is something glitchy going inside the library.

[gravataLonga]

Sorry, why comment's was deleted? Only for curiosity..

[leejoys]

This way it's working:

func main() {
	systray.Run(onReady, onExit)
}

func onReady() {
	systray.SetTitle("Sup")
	systray.SetIcon(ico)
	systray.SetTooltip("Sup")
}

func onExit() {

}

But this way fall to panic:

func main() {
	systray.Run(onReady, onExit)
}

func onReady() {
	systray.SetTitle("Sup")
	systray.SetTooltip("Sup")
	systray.SetIcon(ico)

}

func onExit() {

}