Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify units formatting across the app #1136

Open
2 tasks
stackingsaunter opened this issue Feb 27, 2025 · 1 comment
Open
2 tasks

Unify units formatting across the app #1136

stackingsaunter opened this issue Feb 27, 2025 · 1 comment
Assignees

Comments

@stackingsaunter
Copy link
Contributor

stackingsaunter commented Feb 27, 2025

Small changes to make app more consistent and a bit lighter:

  • Use thin space as thousands separator for sats (for fiat too by default, unless we'll use system/language formatting there?)
  • All sats amounts, regardless of the font size, should me "medium" weight (they're currently not eg. in main Wallet balance and transaction list). Exception: sats amount in tables and in other data structures, eg. tables in Node page or during opening channel flow (they stay "regular")
  • When we introduce fiat amounts, they will be regular weight

Image

@reneaaron
Copy link
Contributor

We rely on system formats for formatting numbers for all locales, we can't (and shouldn't) override these locale specific things with some custom formatting. Have a look at e.g. India, Switzerland, etc. to get an idea of how different these things are handled around the world.

All sats amounts, regardless of the font size, should me "medium" weight

Agree here, we should be more consistent in that regard. Fixed it on the wallet page already, don't know what you exactly refer to when you mention "transaction list"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants