fix: disconnect ldk peer before re-connecting #1150
+8
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bumi
reviewed
Mar 5, 2025
| err := ls.node.Disconnect(connectPeerRequest.Pubkey) | ||
| if err != nil { | ||
| // non-critical: only log an error | ||
| logger.Logger.WithField("request", connectPeerRequest).WithError(err).Error("Disconnect failed while connecting peer") |
There was a problem hiding this comment.
this happens when we're not connected? or when could this happen?
There was a problem hiding this comment.
@bumi I couldn't reproduce it in my testing, both connecting to an existing peer and connecting to a peer that was not currently connected. I looked at the ldk-node code and this can happen if persistence fails (which ideally never happens, if it does we have much bigger issues than disconnecting from a peer).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1113