Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alex transitively depends on a library with a security problem #319

Closed
julienw opened this issue May 11, 2021 · 2 comments
Closed

alex transitively depends on a library with a security problem #319

julienw opened this issue May 11, 2021 · 2 comments

Comments

@julienw
Copy link
Contributor

julienw commented May 11, 2021

Subject of the issue

Alex depends on remark-parse with version requirements ^v8.0.0.
remark-parse v8 depends on trim v0.0.1.
trim v0.0.1 has a regexp-related security problem fixed in v0.0.3, but we can't upgrade it manually because of how semver works.

There are 2 ways to fix this:

  • upgrade remark-parse to v9, which doesn't depend on trim anymore. We can't upgrade manually either because this is a major upgrade (and they changed the underlying markdown parser, which may lead to bugs in alex, so care is needed when upgrading).
  • make remark-parse release a dependency upgrade on the v8 branch.

For more information, here is the advisory for trim: GHSA-w5p7-h5w8-2hfq

Steps to reproduce

Run yarn audit or npm audit on a project that depends on alex.

Thanks!

@wooorm
Copy link
Member

wooorm commented May 11, 2021

This doesn’t really affect alex, or you: it’s quite hard to use alex is a dangerous way.

You could use patch-package to update trim@0.0.1 to trim@1.0.0, which are otherwise identical.

I’m half way in updating all of unified. I’ll update alex in a couple of months!

@wooorm
Copy link
Member

wooorm commented Dec 30, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants