add --recursive support for got clone
#69
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just pass the parameter down to `git`. Fixes genehack#68
genehack
reviewed
May 1, 2018
lib/App/GitGot/Command/clone.pm
Outdated
| @@ -61,7 +62,10 @@ sub _execute { | |||
| $new_entry->{tags} = $tags if $tags; | |||
|
|
|||
| say "Cloning into '$path'..." unless $self->quiet; | |||
| $new_entry->clone( $repo , $path ); | |||
| $new_entry->clone( | |||
| ({ recursive => $self->opt->recursive }) x !!$self->opt->recursive, | |||
There was a problem hiding this comment.
This line leaves me a bit frowny, it feels excessively clever. I haven't tested it, but I think simply passing { recursive => $self->opt->recursive } should DTRT?
There was a problem hiding this comment.
I was playing it safe and just not passing the argument if there was no need, but sure.
|
I just re-implemented this in a local branch using a slightly different approach. It will be in the next release (probably later today). Thanks for the implementation which I mostly ripped off wholesale. |
genehack
added a commit
that referenced
this pull request
Apr 25, 2020
genehack
added a commit
that referenced
this pull request
Apr 25, 2020
* Add 'readd' command to update repo entries in ~/.gitgot based on
what is in working trees (genehack)
* Add .editorconfig (genehack)
* Add `--recursive` option to `clone` command (genehack,
reimplementing yanick's code from #69) [#68]
* switch from File::HomeDir to File::HomeDir::Tiny, for fewer
dependencies (Karen Etheridge) [#70]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just pass the parameter down to
git.Fixes #68