feat(ethexe): add support for FROST signatures to sequencer & validator #4515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StackOverflowExcept1on
added
the
A0-pleasereview
grishasobol
reviewed
Feb 25, 2025
Comment on lines
+275
to
+277
| uint256 _signatureRX, | ||
| uint256 _signatureRY, | ||
| uint256 _signatureZ |
There was a problem hiding this comment.
Could we concat this in one structure?
There was a problem hiding this comment.
make sense
There was a problem hiding this comment.
wdym by incorrect validatos? you mean malicious validators?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for FROST threshold signatures, which require only$\approx 10500$ gas to validate on Ethereum, allowing us to spend 30-40x less gas on large validator set.