refactor(core-code) Optimisation of read-write structures for code instrumentation #4274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or better consistency
breathx
requested changes
Oct 7, 2024
breathx
added
A1-inprogress
…harge architecture was changed to type state pattern
Lazark0x
changed the title
Lazark0x
removed
the
A1-inprogress
ark0f
requested changes
Oct 28, 2024
…n-refactoring # Conflicts: # gclient/src/api/calls.rs
…n-refactoring # Conflicts: # ethexe/runtime/common/src/lib.rs # gtest/src/manager.rs # gtest/src/manager/block_exec.rs # pallets/gear-program/src/migrations/add_section_sizes.rs # pallets/gear-program/src/migrations/v12_program_code_id_migration.rs # pallets/gear/src/tests.rs # runtime/vara/src/migrations.rs
# Conflicts: # core-processor/src/lib.rs # ethexe/runtime/common/src/lib.rs # pallets/gear-builtin/src/lib.rs # pallets/gear-program/src/migrations/add_section_sizes.rs # pallets/gear-program/src/migrations/v12_program_code_id_migration.rs
ark0f
requested changes
Jan 17, 2025
There was a problem hiding this comment.
Remove the migration. It was already executed on chain
There was a problem hiding this comment.
I don't think it was executed, it's about transforming H256 into CodeId
Line 101 in 4cbcece
There was a problem hiding this comment.
Migration is removed from the master branch
pallets/gear-program/src/migrations/v11_code_metadata_delete_migration.rs
Outdated
Show resolved
Hide resolved
pallets/gear-program/src/migrations/v13_split_instrumented_code_migration.rs
Outdated
Show resolved
Hide resolved
Comment on lines
+125
to
+132
| if !code_metadata.exports().contains(&dispatch_kind) { | ||
| let (destination_id, dispatch, gas_counter, _) = context.into_parts(); | ||
|
|
||
| // Load instrumented binary code from storage. | ||
| let code = T::CodeStorage::get_code(code_id).unwrap_or_else(|| { | ||
| // `Program` exists, so do code and code len. | ||
| let err_msg = format!( | ||
| "run_queue_step: failed to get code for the existing program. \ | ||
| Program id -'{destination_id:?}', Code id - '{code_id:?}'." | ||
| return core_processor::process_success( | ||
| SuccessfulDispatchResultKind::Success, | ||
| DispatchResult::success(dispatch, destination_id, gas_counter.to_amount()), | ||
| ); | ||
| } |
There was a problem hiding this comment.
Should be executed after reinstrumentation
There was a problem hiding this comment.
hmm, is it really possible for exports to change after re-instrumentation?
There was a problem hiding this comment.
added a note to rewrite in case re-instrumentation will modify exports
# Conflicts: # core/src/code/mod.rs # ethexe/common/src/db.rs # ethexe/db/src/database.rs # ethexe/processor/src/host/mod.rs # pallets/gear-program/src/migrations/mod.rs # pallets/gear-program/src/migrations/v12_program_code_id_migration.rs # pallets/gear/src/lib.rs # pallets/gear/src/tests.rs # runtime/vara/src/migrations.rs # utils/calc-stack-height/src/main.rs # utils/wasm-builder/src/code_validator.rs
…n-refactoring # Conflicts: # gtest/src/manager.rs # gtest/src/manager/memory.rs
…n-refactoring # Conflicts: # ethexe/processor/src/host/mod.rs # ethexe/runtime/common/src/lib.rs # ethexe/runtime/src/wasm/api/run.rs # gcli/src/meta/mod.rs
…n-refactoring # Conflicts: # ethexe/db/src/database.rs # runtime/vara/src/migrations.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code structure constructor now returns 3 parameters: InstrumentedCode, OriginalCode and CodeMetadata
CodeMetadata contains all the necessary data to infer the need for code instrumentation
Rewritten precharge to type-state pattern