Skip to content

Commit aa87df1

Browse files
Attempt to fix bug caused by LINS_MaxPGenerators being too low.
Unfortunately the method `PQuotient` ungracefully throws an error, instead of returning fail.
1 parent 82e54d5 commit aa87df1

File tree

1 file changed

+4
-8
lines changed

1 file changed

+4
-8
lines changed

gap/findPQuotients.gi

+4-8
Original file line numberDiff line numberDiff line change
@@ -176,13 +176,6 @@ BindGlobal("LINS_PullBackH", function(GenM, p, Gens, O, Mu, Psi)
176176
end);
177177

178178

179-
#############################################################################
180-
## maximal generators of a p-quotient.
181-
#############################################################################
182-
183-
BindGlobal("LINS_MaxPGenerators", 1000);
184-
185-
186179
#############################################################################
187180
## LINS_FindPModules
188181
#############################################################################
@@ -225,6 +218,8 @@ InstallGlobalFunction(LINS_FindPModules, function(gr, rH, p, opts)
225218
n, # pos-int: index bound of LINS graph `gr`.
226219
Iso, # isomorphism: from `H` into fp-group
227220
IH, # fp-group: image under `Iso`, isomorphic to `H`
221+
logord, # int: option for PQuotient, the maximal order
222+
# for P we consider is p^logord
228223
P, # quotsys: p-quotient of `IH` of class 1
229224
Mu, # epimorphism: from `IH` into `P`
230225
M, # pc-group: image under `Mu`
@@ -272,7 +267,8 @@ InstallGlobalFunction(LINS_FindPModules, function(gr, rH, p, opts)
272267
IH := Image(Iso);
273268

274269
# Create the Isomorphism to the group structure of the `p`-Module `M`
275-
P := PQuotient(IH, p, 1, LINS_MaxPGenerators);
270+
logord := Int(Log(Float(n / rH!.Index))/Log(Float(p)));
271+
P := PQuotient(IH, p, 1, logord);
276272
Mu := EpimorphismQuotientSystem(P);
277273
M := Image(Mu);
278274
GenM := GeneratorsOfGroup(M);

0 commit comments

Comments
 (0)