Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable apply_delens=True in CMBLensed #214

Merged
merged 5 commits into from
Mar 20, 2025

Conversation

JamesAmato
Copy link
Contributor

fix: apply_delens=True in CMBLensed previously caused a ValueError ( #213 ).

I included a notebook at the top level to avoid import issues. Let me know if you'd like me to move it elsewhere.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@JamesAmato
Copy link
Contributor Author

There's a flaw in the notebook that I failed to notice (spectra are not included in the PR). I'll find another approach.

@JamesAmato JamesAmato closed this Feb 28, 2025
@JamesAmato JamesAmato reopened this Feb 28, 2025
@JamesAmato
Copy link
Contributor Author

There was a fast fix without needing external files.

Copy link
Member

@zonca zonca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for your contribution, just small fixes

@zonca
Copy link
Member

zonca commented Mar 19, 2025

@JamesAmato please look at my feedback

@JamesAmato
Copy link
Contributor Author

I missed this; I apologize.

@zonca zonca merged commit adb0a17 into galsci:main Mar 20, 2025
4 checks passed
@zonca
Copy link
Member

zonca commented Mar 20, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants