Skip to content

Commit 047d783

Browse files
committed
test: fix phpbench
1 parent 6f868a9 commit 047d783

File tree

15 files changed

+33
-34
lines changed

15 files changed

+33
-34
lines changed

CHANGELOG.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -229,7 +229,7 @@
229229
- Moved the "config readers" next to their config item itself
230230
- Performance improvement specially when using different config readers in the same project
231231
- Added OverrideResolvableTypes feature
232-
- Allow overriding Gacela resolvable types (Factory, Config, AbstractProvider)
232+
- Allow overriding Gacela resolvable types (Factory, Config, DependencyProvider)
233233
- Removed deprecated methods `getApplicationRootDir()` & `setApplicationRootDir()` from Config
234234
- Use `getAppRootDir()` & `setAppRootDir()` instead
235235
- Deprecated and removed `CustomService` feature. Use `MappingInterfaces` feature instead
@@ -303,5 +303,5 @@
303303

304304
## [0.1.0](https://github.com/gacela-project/gacela/compare/690484441389a2d3bd921ab7f278c6d945f50cac...0.1.0) - 2021-04-02
305305

306-
- Added Facade, Factory, Config and AbstractProvider basic functionality
306+
- Added Facade, Factory, Config and DependencyProvider basic functionality
307307
- Provide documentation for each of these concepts with examples

README.md

+3-3
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,8 @@ It encourages your modules to interact with each other in a unified way by follo
3838
- Modules interact with each other **only** via their **Facade**
3939
- The [**Facade**](https://gacela-project.com/docs/facade/) is the *entry point* of a module
4040
- The [**Factory**](https://gacela-project.com/docs/factory/) manage the *intra-dependencies* the module
41-
- The [**AbstractProvider**](https://gacela-project.com/docs/dependency-provider/) resolves the *extra-dependencies* of the module
42-
- The [**Config**](https://gacela-project.com/docs/config/) has access to the project's *config files*
41+
- The [**Provider**](https://gacela-project.com/docs/provider/) resolves the *extra-dependencies* of the module
42+
- The [**Config**](https://gacela-project.com/docs/config/) access the project's *config files*
4343

4444
### Installation
4545

@@ -70,7 +70,7 @@ application-name
7070
│ │ │ # These are the 4 "gacela classes":
7171
│ │ ├── Facade.php
7272
│ │ ├── Factory.php
73-
│ │ ├── AbstractProvider.php
73+
│ │ ├── Provider.php
7474
│ │ └── Config.php
7575
│ │
7676
│ └── ModuleB

src/Console/Domain/AllAppModules/AppModuleCreator.php

+4-4
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ final class AppModuleCreator
1717
public function __construct(
1818
private readonly FactoryResolver $factoryResolver,
1919
private readonly ConfigResolver $configResolver,
20-
private readonly ProviderResolver $dependencyProviderResolver,
20+
private readonly ProviderResolver $providerResolver,
2121
) {
2222
}
2323

@@ -32,7 +32,7 @@ public function fromClass(string $facadeClass): AppModule
3232
$facadeClass,
3333
$this->findFactory($facadeClass),
3434
$this->findConfig($facadeClass),
35-
$this->findAbstractProvider($facadeClass),
35+
$this->findProvider($facadeClass),
3636
);
3737
}
3838

@@ -89,10 +89,10 @@ private function findConfig(string $facadeClass): ?string
8989
/**
9090
* @param class-string $facadeClass
9191
*/
92-
private function findAbstractProvider(string $facadeClass): ?string
92+
private function findProvider(string $facadeClass): ?string
9393
{
9494
try {
95-
$resolver = $this->dependencyProviderResolver->resolve($facadeClass);
95+
$resolver = $this->providerResolver->resolve($facadeClass);
9696

9797
if ((new ReflectionClass($resolver))->isAnonymous()) {
9898
throw new ProviderNotFoundException($resolver);

src/Framework/AbstractFactory.php

+2-2
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,8 @@ private function createContainerWithProvidedDependencies(): Container
4343
{
4444
$container = Container::withConfig(Config::getInstance());
4545

46-
$dependencyProvider = (new ProviderResolver())->resolve($this);
47-
$dependencyProvider->provideModuleDependencies($container);
46+
$provider = (new ProviderResolver())->resolve($this);
47+
$provider->provideModuleDependencies($container);
4848

4949
return $container;
5050
}

src/Framework/Bootstrap/GacelaConfig.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ public function addSuffixTypeConfig(string $suffix): self
120120
/**
121121
* Allow overriding gacela dependency provider suffixes.
122122
*/
123-
public function addSuffixTypeAbstractProvider(string $suffix): self
123+
public function addSuffixTypeProvider(string $suffix): self
124124
{
125125
$this->suffixTypesBuilder->addProvider($suffix);
126126

src/Framework/ClassResolver/GlobalInstance/AnonymousGlobal.php

-1
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@ final class AnonymousGlobal
2222
'Config',
2323
'Factory',
2424
'Provider',
25-
'Provider',
2625
];
2726

2827
/** @var array<string,object> */

src/Framework/Config/GacelaFileConfig/GacelaConfigFileInterface.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ public function getBindings(): array;
2323
* @return array{
2424
* Factory?:list<string>,
2525
* Config?:list<string>,
26-
* AbstractProvider?:list<string>
26+
* Provider?:list<string>
2727
* }
2828
*/
2929
public function getSuffixTypes(): array;

tests/Benchmark/Framework/ClassResolver/AnonymousGlobal/AnonymousGlobalsBench.php

+9-9
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ public function setUp(): void
3232
public function bench_class_resolving(): void
3333
{
3434
$this->facade->getConfigValues();
35-
$this->facade->getValueFromAbstractProvider();
35+
$this->facade->getValueFromProvider();
3636
}
3737

3838
private function setupAbstractConfig(): void
@@ -71,13 +71,13 @@ public function createDomainClass(): object
7171
/** @var array $configValues */
7272
$configValues = $this->getConfig()->getValues();
7373

74-
/** @var string $valueFromAbstractProvider */
75-
$valueFromAbstractProvider = $this->getProvidedDependency('key');
74+
/** @var string $valueFromProvider */
75+
$valueFromProvider = $this->getProvidedDependency('key');
7676

77-
return new class($configValues, $valueFromAbstractProvider) {
77+
return new class($configValues, $valueFromProvider) {
7878
public function __construct(
7979
private readonly array $configValues,
80-
private readonly string $valueFromAbstractProvider,
80+
private readonly string $valueFromProvider,
8181
) {
8282
}
8383

@@ -86,9 +86,9 @@ public function getConfigValues(): array
8686
return $this->configValues;
8787
}
8888

89-
public function getValueFromAbstractProvider(): string
89+
public function getValueFromProvider(): string
9090
{
91-
return $this->valueFromAbstractProvider;
91+
return $this->valueFromProvider;
9292
}
9393
};
9494
}
@@ -106,11 +106,11 @@ public function getConfigValues(): array
106106
->getConfigValues();
107107
}
108108

109-
public function getValueFromAbstractProvider(): string
109+
public function getValueFromProvider(): string
110110
{
111111
return $this->getFactory()
112112
->createDomainClass()
113-
->getValueFromAbstractProvider();
113+
->getValueFromProvider();
114114
}
115115
};
116116
}

tests/Benchmark/Framework/ClassResolver/FileCache/FileCacheBench.php

+5-5
Original file line numberDiff line numberDiff line change
@@ -65,11 +65,11 @@ private function gacelaBootstrapWithCache(bool $cacheEnabled): void
6565
$config->addSuffixTypeConfig('ConfigD');
6666
$config->addSuffixTypeConfig('ConfigE');
6767

68-
$config->addSuffixTypeAbstractProvider('DepProvA');
69-
$config->addSuffixTypeAbstractProvider('DepProvB');
70-
$config->addSuffixTypeAbstractProvider('DepProvC');
71-
$config->addSuffixTypeAbstractProvider('DepProvD');
72-
$config->addSuffixTypeAbstractProvider('DepProvE');
68+
$config->addSuffixTypeProvider('DepProvA');
69+
$config->addSuffixTypeProvider('DepProvB');
70+
$config->addSuffixTypeProvider('DepProvC');
71+
$config->addSuffixTypeProvider('DepProvD');
72+
$config->addSuffixTypeProvider('DepProvE');
7373
});
7474
}
7575

tests/Benchmark/Framework/ClassResolver/FileCache/ModuleG/ModuleGDependencyProvider.php renamed to tests/Benchmark/Framework/ClassResolver/FileCache/ModuleG/ModuleGProvider.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
use Gacela\Framework\AbstractProvider;
88
use Gacela\Framework\Container\Container;
99

10-
final class ModuleGAbstractProvider extends AbstractProvider
10+
final class ModuleGProvider extends AbstractProvider
1111
{
1212
public function provideModuleDependencies(Container $container): void
1313
{

tests/Benchmark/Framework/ClassResolver/NormalModule/NormalModuleDependencyProvider.php renamed to tests/Benchmark/Framework/ClassResolver/NormalModule/NormalModuleProvider.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
use Gacela\Framework\AbstractProvider;
88
use Gacela\Framework\Container\Container;
99

10-
final class NormalModuleAbstractProvider extends AbstractProvider
10+
final class NormalModuleProvider extends AbstractProvider
1111
{
1212
public function provideModuleDependencies(Container $container): void
1313
{

tests/Feature/Framework/UsingCustomSuffixTypes/gacela.php

+2-2
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,10 @@
1212
->addSuffixTypeFacade('FacaModuleA')
1313
->addSuffixTypeFactory('FactModuleA')
1414
->addSuffixTypeConfig('ConfModuleA')
15-
->addSuffixTypeAbstractProvider('ProModuleA')
15+
->addSuffixTypeProvider('ProModuleA')
1616
// ModuleB
1717
->addSuffixTypeFacade('FacadeModuleB')
1818
->addSuffixTypeFactory('FactoryModuleB')
1919
->addSuffixTypeConfig('ConfigModuleB')
20-
->addSuffixTypeAbstractProvider('ProviderModuleB');
20+
->addSuffixTypeProvider('ProviderModuleB');
2121
};

tests/Integration/Framework/Config/ConfigFactory/WithGacelaFile/gacela.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,4 +11,4 @@
1111
->addSuffixTypeFacade('FacadeFromGacelaFile')
1212
->addSuffixTypeFactory('FactoryFromGacelaFile')
1313
->addSuffixTypeConfig('ConfigFromGacelaFile')
14-
->addSuffixTypeAbstractProvider('AbstractProviderFromGacelaFile');
14+
->addSuffixTypeProvider('AbstractProviderFromGacelaFile');

tests/Unit/Framework/Config/GacelaFileConfig/Factory/GacelaConfigUsingGacelaPhpFileFactoryTest.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@ public function test_gacela_file_set_suffix_types(): void
102102
$fileIo = $this->createStub(FileIoInterface::class);
103103
$fileIo->method('include')->willReturn(
104104
static fn (GacelaConfig $config): GacelaConfig => $config
105-
->addSuffixTypeAbstractProvider('Binding'),
105+
->addSuffixTypeProvider('Binding'),
106106
);
107107

108108
$factory = new GacelaConfigUsingGacelaPhpFileFactory(

0 commit comments

Comments
 (0)