Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added pkg-config file #509

Merged
merged 1 commit into from
May 30, 2016
Merged

Added pkg-config file #509

merged 1 commit into from
May 30, 2016

Conversation

gsliepen
Copy link

Apparently, some projects depending on glm expect it to have a .pc file (see https://bugs.debian.org/737088). Here's a patch that adds one.

@Groovounet Groovounet self-assigned this May 30, 2016
@Groovounet Groovounet added this to the GLM 0.9.7 milestone May 30, 2016
@Groovounet Groovounet merged commit d69616b into g-truc:master May 30, 2016
@Groovounet
Copy link
Member

Hi,

Is it required that glm.pc.in remains in GLM root directory?
I'll rather keep it hidden (inside "cmake" directory?) to avoid polluting the root folder with files that only few users actually need.

Thanks,
Christophe

@gsliepen
Copy link
Author

On Mon, May 30, 2016 at 11:21:38AM -0700, Christophe wrote:

Is it required that glm.pc.in remains in GLM root directory?

Not at all.

I'll rather keep it hidden (inside "cmake" directory?) to avoid polluting the root folder with files that only few users actually need.

Sure, that's fine. As long as it gets installed in the proper location
it doesn't matter where it is in the source :)

Met vriendelijke groet / with kind regards,
Guus Sliepen guus@tinc-vpn.org

Groovounet added a commit that referenced this pull request May 30, 2016
@Groovounet
Copy link
Member

Ok, can you review the change b4df7d6?

Thanks!

Groovounet added a commit that referenced this pull request May 31, 2016
@gsliepen
Copy link
Author

gsliepen commented Jun 1, 2016

On Mon, May 30, 2016 at 03:37:07PM -0700, Christophe wrote:

Ok, can you review the change b4df7d6?

That works perfectly fine.

Met vriendelijke groet / with kind regards,
Guus Sliepen guus@tinc-vpn.org

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants