Introduce the ability to allow most explicit conversions to be implicit #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use the new GLM_IMPLICIT_CONVERSION_CTOR #define - By default GLM_EXPLICIT_CONV is defined as "explicit" - #define GLM_IMPLICIT_CONVERSION_CTOR defines it as empty
|
@Groovounet Any thoughts on this PR? |
|
Huh, I guess 251ad15 works too. Thank you! |
|
I applied your changes based on the existing GLM_FORCE_EXPLICIT_CTOR instead of adding another #define and made sure the coverage is exhaustive. Thanks, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I feel this is a better way to solve the problem I proposed in #421 ; namely, converting between various GLM types freely in a manner suited to template metaprogramming. Except now instead of registering a function pointer, I can just declare the existence of an implicit conversion, and just tell
QVariantto use it. This should greatly simplify the original file that I was concerned about, without introducing any more complexity to GLM.By the way, my other PR #458 is ready to merge, pending your approval (I'd nearly forgotten about it, actually).