Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

glm::vec<L,T,P>::length() should be marked constexpr where supported #657

Closed
aheysse opened this issue Jul 14, 2017 · 1 comment
Closed

glm::vec<L,T,P>::length() should be marked constexpr where supported #657

aheysse opened this issue Jul 14, 2017 · 1 comment
Assignees
@Groovounet
Milestone
GLM 0.9.9

Comments

@aheysse
Copy link

aheysse commented Jul 14, 2017

As far as I can tell, there is no way to get the length of a glm::vec without using glm::vec::length(). Marking length as constexpr when compilers support it would allow for compile time deduction of the function. This could be useful when writing template code that consumes glm::vec.

Cheers
Groovounet added a commit that referenced this issue Jul 24, 2017
@Groovounet
length() member functions are constexpr #657
1b78e2b
@Groovounet Groovounet self-assigned this Jul 24, 2017
@Groovounet Groovounet added this to the GLM 0.9.9 milestone Jul 24, 2017
@Groovounet
Copy link
Member

This issue is fixed in master branch for GLM 0.9.9 release.

Thanks for contributing,
Christophe

Groovounet added a commit that referenced this issue Jul 24, 2017
@Groovounet
Added length constexpr test #657
9443d8d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Groovounet Groovounet

Labels
None yet
Projects
None yet
Milestone
GLM 0.9.9
Development

No branches or pull requests
2 participants
@Groovounet @aheysse