Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake version specification doesn't work #572

Closed
rutsky opened this issue Nov 11, 2016 · 7 comments
Closed

CMake version specification doesn't work #572

rutsky opened this issue Nov 11, 2016 · 7 comments
Assignees
Labels
Milestone

Comments

@rutsky
Copy link

rutsky commented Nov 11, 2016

I'm using GLM version 0.9.8.1 from Debian package on 64-bit GNU/Linux (https://packages.debian.org/sid/libglm-dev).
When I'm trying to specify in my CMakeLists.txt minimal required GLM version:

find_package(glm 0.9.8 REQUIRED)

I get CMake error:

CMake Error at CMakeLists.txt:21 (find_package):
  Could not find a configuration file for package "glm" that is compatible
  with requested version "0.9.8".

  The following configuration files were considered but not accepted:

    /usr/lib/cmake/glm/glmConfig.cmake, version: unknown



*** cmake process exited with exit code 1.

Requirement without version specification works fine:

find_package(glm REQUIRED)
@Groovounet
Copy link
Member

@shaxbee who contributed this feature in #324 might be interested to have a look.

Thanks for reporting,
Christophe

@shaxbee
Copy link

shaxbee commented Nov 12, 2016

Could you be so kind and elaborate? What doesn't work?

On Sat, Nov 12, 2016, 6:14 PM Christophe notifications@github.com wrote:

@shaxbee https://github.com/shaxbee who contributed this feature in #324
#324 might be interested to have a
look.

Thanks for reporting,
Christophe


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#572 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AE_mfXtLuauCctRF10avz5Dfp2YSouiEks5q9ZGUgaJpZM4KwAju
.

@shaxbee
Copy link

shaxbee commented Nov 12, 2016

Sorry, I see the problem. PR will follow shortly.

@shaxbee
Copy link

shaxbee commented Nov 12, 2016

Seems like I named version file incorrectly - according to Package_Version_Files it should be glmConfigVersion.cmake not glmVersion.cmake.

See #573.
Once it is included in release you can use it with ExternalProject as follows:

externalproject_add(glm URL https://github.com/g-truc/glm/releases/download/<version>/glm-<version>.zip URL_MD5 <hash>)

@Groovounet
Copy link
Member

Thanks @shaxbee for the quick resolution. Having a quick look I noticed this file name different but I haven't sue it matters.

@rutsky, it would be great if you could have a look to double check it's working just fine for you.

This is issue should be fixed in GLM 0.9.8 branch for GLM 0.9.8.3 release and in master branch.

Thanks,
Christophe

@Groovounet Groovounet self-assigned this Nov 12, 2016
@Groovounet Groovounet added this to the GLM 0.9.8 milestone Nov 12, 2016
@rutsky
Copy link
Author

rutsky commented Nov 14, 2016

@shaxbee thanks for the quick fix!

@Groovounet I can confirm that renaming glmVersion.cmake to glmConfigVersion.cmake fixes the issue on my system.

@Groovounet
Copy link
Member

Thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants