use Prettier from tslint to piggyback on exclusions

also, let tslint do linebreak style assertions

Author: joonas-fi

Dockerfile

@@ -14,8 +14,9 @@ RUN apt update && apt install -y zip \
 		yarn@1.12.3 \
 		typescript@3.1.1 \
 		tslint@5.11.0 \
-		aws-sdk@2.290.0 \
+		tslint-plugin-prettier@2.0.1 \
 		prettier@1.15.3 \
+		aws-sdk@2.290.0 \
 		@types/node@8.10.34 \
 		@types/aws-lambda@8.10.13 \
 	&& ln -s /usr/local/lib/node_modules /node_modules

README.md

@@ -16,7 +16,5 @@ Contains
 - [TypeScript](https://www.typescriptlang.org/) compiler & some @types
 - [Prettier](https://prettier.io/) to standardize code formatting
 - [tslint](https://palantir.github.io/tslint/) for static analysis
-- [jfrog-cli](https://github.com/jfrog/jfrog-cli-go) to upload artefacts to
-  [Bintray](https://bintray.com/) (e.g. .zip files for Lambda)
 - Build script to standardize build process across projects
-- Standardized configuration for ensuring highest possible quality code
+- Standardized TypeScript/tslint/Prettier configuration for ensuring highest possible quality code

build-common.sh

@@ -21,15 +21,6 @@ _copyTsConfigAndTslint() {
 	fi
 }
 
-_checkFormatting() {
-	local offenders=$(prettier --list-different --config /etc/prettier-config.json '**/*.ts' '**/*.tsx')
-
-	if [ ! -z "$offenders" ]; then
-		>&2 echo "formatting errors: $offenders"
-		exit 1
-	fi
-}
-
 _setupReleaseDirectory() {
 	mkdir -p rel/
 }
@@ -39,6 +30,7 @@ _compileTypescript() {
 }
 
 _runStaticAnalysis() {
+	# code formatting (prettier.io) is also checked here
 	tslint --project .
 }
 
@@ -57,7 +49,5 @@ standardBuildProcess() {
 
 	buildstep runStaticAnalysis
 
-	buildstep checkFormatting
-
 	buildstep tests
 }

prettier-config.json

@@ -4,7 +4,6 @@
 	"singleQuote": true,
 	"arrowParens": "always",
 	"jsxBracketSameLine": true,
-	"endOfLine": "lf",
 	"printWidth": 100,
 	"trailingComma": "all"
 }

tslint.json

@@ -1,12 +1,11 @@
 {
-	"linterOptions": {
-		"exclude": [
-		]
-	},
 	"extends": [
-		"tslint:recommended"
+		"tslint:recommended",
+		"tslint-plugin-prettier"
 	],
 	"rules": {
+		"prettier": [true, "/etc/prettier-config.json"],
+		"linebreak-style": [true, "LF"],
 		"member-access": false,
 		"indent": [true, "tabs"],
 		"interface-name": false,