New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change CredentialsProvider to require an exported method #21

Open

JohnAnthony wants to merge 1 commit into fullcontact:master from JohnAnthony:satisfiable-credentials-provider-interface

JohnAnthony commented Oct 1, 2024 •

edited

Loading

I believe this will resolve #20

CredentialsProvider now requires a method of GetApiKey rather than getApiKey and can be satisfied by implementations outside of this library
The two implementations in this library (DefaultCredentialsProvider and StaticCredentialsProvider) have been changed to continue to satisfy the interface
Because the interface was only satisfiable by these internal implementations and their unexported methods, I think this is a non-breaking change


          change CredentialsProvider to require an exported method

2ae24b9

JohnAnthony force-pushed the satisfiable-credentials-provider-interface branch from e3f8372 to 2ae24b9 Compare

October 1, 2024 09:03

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet