Skip to content

Commit 794213e

Browse files
committed
Signal(SIGINT) needs to be injected to the server executable.
Signed-off-by: Tomoya.Fujita <tomoya.fujita825@gmail.com>
1 parent d10dd0a commit 794213e

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

README.md

+4
Original file line numberDiff line numberDiff line change
@@ -256,6 +256,10 @@ All of the test is listed with result as following
256256
- `[1.0,1.1]` is deduced as `[1, 1.1000000000000001]` because of [yaml-cpp bug](https://github.com/jbeder/yaml-cpp/issues/1016), this will leads to `Failed to parse parameters` exception when loading the persistent parameters from yaml file.
257257
- The work-around is to use string sequence `["1.0", "1.1"]` instead of double type, then change it into `float()` in the program.
258258

259+
- [Signal2(2) needs to be injected to the server executable](https://github.com/fujitatomoya/ros2_persist_parameter_server/issues/24)
260+
- Because of https://github.com/ros2/ros2cli/pull/899 and [What is main process in container](https://docs.docker.com/engine/containers/multi-service_container/), signal (SIGINT/SIGTERM) does not directly go to the server process. This causes the server not to store the persistent parameters in the file system, since the server expects the signal to shutdown the process and store the all persistent parameters in the specified file system.
261+
- The work-around is that, configure container main process with the server executables (not using `ros2 run` until https://github.com/ros2/ros2cli/pull/899 is solved) or send the signal from the host system to the server process in the container using `docker exec <YOUR CONTAINER> kill -SIGINT <SERVER PID IN CONTAINER>`.
262+
259263
## Authors
260264

261265
- **Tomoya Fujita** --- Tomoya.Fujita@sony.com

0 commit comments

Comments
 (0)