Incorrect output format property generation in Fake.DotNet.Testing.Coverlet

[SteveGilham]

Description

It generates /p:OutputFormat=opencover when it should be /p:CoverletOutputFormat=opencover -- see documentation

Repro steps

Use

let coverletOptions (o : Coverlet.CoverletParams) = 
  { o with OutputFormat = Coverlet.OutputFormat.OpenCover }
...
Coverlet.withDotNetTestOptions coverletOptions

in

Expected behavior

Command line for dotnet test includes

 /p:CollectCoverage=true /p:CoverletOutputFormat=opencover /p:CoverletOutput=./

and the call generates an XML report coverage.opencover,xml

Actual behavior

Command line for dotnet test includes

 /p:CollectCoverage=true /p:OutputFormat=opencover /p:CoverletOutput=./

and the call generates a JSON report coverage.json

Known workarounds

Compose that part of the command line manually like

let coverlet5_18_3fixup (o : DotNet.TestOptions) =      
  if o.MSBuildParams.Properties |> List.exists (fun (p,_) -> p = "CoverletOutput")
  then { o with MSBuildParams = { o.MSBuildParams with Properties = o.MSBuildParams.Properties 
                                                                    |> List.map (fun (p,v) -> if p = "OutputFormat"
                                                                                              then ("CoverletOutputFormat", v)
                                                                                              else (p,v))}}
  else o       

Coverlet.withDotNetTestOptions coverletOptions
|> coverlet5_18_3fixup

Related information

Fake 5.18.3