[Opinion] Expecto Runner should not pass any parameters by default

[0x53A]

Unittest DLL:

Runner.RunTestsWithArgs(Impl.ExpectoConfig.defaultConfig.WithParallel(false), args, ...)

Fake script:

Fake.DotNet.Testing.Expecto.run id [ testExe ]

Expected:

Just logically speaking, I have set parallel to false in the exe, have not specified anything in my script, so I expect it to run serially.

Actual:

command-line:

Tests.exe --parallel --parallel-workers 0 --fail-on-focused-tests --version

Instead fake passes --parallel and so the tests run in parallel.

Workaround 1:

Fake.DotNet.Testing.Expecto.run (fun o -> {o with Parallel = false }) [ testExe ]

Workaround 2:

in the c# test-exe:

args = args.Except(new[] { "--parallel" }).ToArray();

Fix:

This would be a breaking change, but the proper fix would be to make the properties Options. If they are not set, they stay at None and are not passed to the exe.

[matthid]

Yes PR would be welcome :)

[matthid]

If you don't specify anything in the command line it will run parallel as well, correct (afaik that is just the default in expecto)?

[0x53A]

Yeah, I think so

[matthid]

We could just set the default to false which would change the behavior in fake to not pass the argument at all