Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FAKE should select the correct msbuild, based on VisualStudioVersion parameter #1452

Closed
hmemcpy opened this issue Jan 17, 2017 · 0 comments
Closed

Comments

@hmemcpy
Copy link
Contributor

hmemcpy commented Jan 17, 2017

When building Visual Studio extensions, msbuild version has an important significance. Each VS version has its own msbuild, and FAKE should invoke the correct one.

Right now, there's a very simple lookup for an installed MSBuild version. While this may work well for most C#/F# projects, it doesn't work with version-specific projects, such as Visual Studio extensions.

VS-specific FAKE scripts pass in the VisualStudioVersion parameter (either taken from the environment variables of the Developer Command Shell, or a default value) - see https://github.com/fsprojects/Paket.VisualStudio/blob/master/build.fsx#L105

FAKE should consider VisualStudioVersion parameter, if exists, when looking for the location of msbuild.exe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant