Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TeamCity should build with nodereuse-false as default? #1109

Closed
bjartwolf opened this issue Jan 23, 2016 · 4 comments
Closed

TeamCity should build with nodereuse-false as default? #1109

bjartwolf opened this issue Jan 23, 2016 · 4 comments

Comments

@bjartwolf
Copy link
Contributor

As commented on http://theimowski.com/blog/2016/01-18-continuous-delivery-with-fake-paket-and-teamcity/index.html I think running with

MSBuildDefaults <- { MSBuildDefaults with NodeReuse = false}

is the way to go on TeamCity, as for example the stylecop.dll's will be locked for, I think, 60 seconds if nodereuse is on. This causing clean to fail if the next build comes within 60 seconds of the previous completing. This caused issues for us and we have been running with node-reuse off in all our build scripts for months now.

@theimowski
Copy link
Member

maybe another option could be if you checked the "clean checkout directory" before building on TeamCity?

@bjartwolf
Copy link
Contributor Author

Yes. But I'm not sure how to detect that. Have to look into it and check if this is an environment variable we can read in Fake.

@forki
Copy link
Member

forki commented Jan 24, 2016

MSBuildDefaults <- { MSBuildDefaults with NodeReuse = false}

we could set this automatically when we detect TC as host

@bjartwolf
Copy link
Contributor Author

That is what I was thinking, I'll send a PR in the not to distant future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants