From 94d7dc7e61993996d99a680487c13ea3ceb525e9 Mon Sep 17 00:00:00 2001
From: Ben Taylor <ben.taylor.uk@gmail.com>
Date: Fri, 15 Jan 2016 21:21:45 +0000
Subject: [PATCH] WIP Function to remove Compile elems missing files

As well as keeping project files in sync, I also need to be able to remove compile nodes from a project, where the Include attribute points to a file that is missing.  This is useful when I have two projects including the same files, and I delete a bunch of them from the 'master' project I happen to be working on.

This PR adds two functions.  RemoveCompileNodesWithMissingFiles is intended for build script use and removeCompileNodesWithMissingFiles exists for testing purposes, because unlike the former, it does not write to the file system.  I noticed this convention elsewhere in FAKE, but I'm not sure if it is considered idiomatic.  Let me know.
---
 src/app/FakeLib/MSBuild/ProjectSystem.fs      | 20 +++++-
 src/test/Test.FAKECore/ProjectSystemSpecs.cs  | 28 ++++++++-
 .../ProjectTestFiles/CSharpApp.csproj         | 62 +++++++++++++++++++
 src/test/Test.FAKECore/Test.FAKECore.csproj   |  3 +
 4 files changed, 111 insertions(+), 2 deletions(-)
 create mode 100644 src/test/Test.FAKECore/ProjectTestFiles/CSharpApp.csproj

diff --git a/src/app/FakeLib/MSBuild/ProjectSystem.fs b/src/app/FakeLib/MSBuild/ProjectSystem.fs
index 9cc2e312f78..1646e2f9191 100644
--- a/src/app/FakeLib/MSBuild/ProjectSystem.fs
+++ b/src/app/FakeLib/MSBuild/ProjectSystem.fs
@@ -159,4 +159,22 @@ let CompareProjectsTo templateProject projects =
         |> toLines
 
     if isNotNullOrEmpty errors then
-        failwith errors
\ No newline at end of file
+        failwith errors
+        
+let removeCompileNodesWithMissingFiles includeExistsF (project:ProjectFile) =
+    let projectDir = System.IO.Path.GetDirectoryName(project.ProjectFileName)
+    let missingFiles =
+        seq { for filePath in project.Files do
+                let includePath = System.IO.Path.Combine([|projectDir; filePath|])
+                if not (includeExistsF(includePath)) then yield filePath }
+    missingFiles
+    |> Seq.fold (fun (project:ProjectFile) file -> project.RemoveFile(file)) project
+
+/// Removes projects Compile nodes that have Include attributes pointing to files missing from the file system.  Saves updated projects.
+let RemoveCompileNodesWithMissingFiles project =
+    let newProject = removeCompileNodesWithMissingFiles System.IO.File.Exists (ProjectFile.FromFile project)
+    newProject.Save()
+
+
+
+         
diff --git a/src/test/Test.FAKECore/ProjectSystemSpecs.cs b/src/test/Test.FAKECore/ProjectSystemSpecs.cs
index b078bd7d463..9e22be6d485 100644
--- a/src/test/Test.FAKECore/ProjectSystemSpecs.cs
+++ b/src/test/Test.FAKECore/ProjectSystemSpecs.cs
@@ -1,4 +1,7 @@
-using Fake.MSBuild;
+using System;
+using System.Collections.Generic;
+using System.IO;
+using Fake.MSBuild;
 using Machine.Specifications;
 
 namespace Test.FAKECore
@@ -76,4 +79,27 @@ public class when_removing_duplicate_files
             _project.FindDuplicateFiles().ShouldContain("Git\\CommitMessage.fs");
 
     }
+
+    public class when_removing_compile_nodes_with_missing_files
+    {
+        const string ProjectFilePath = @"ProjectTestFiles/CSharpApp.csproj";
+        private static ProjectSystem.ProjectFile _project;
+
+        private Because of = () =>
+        {
+            Func<string, bool> fileExists = s =>
+            {
+                var pathsToRemove = new List<string>() {Path.Combine("ProjectTestFiles", "Class1.cs"), Path.Combine("ProjectTestFiles", "Folder", "FolderFile2.cs")};
+                return !pathsToRemove.Exists(pathToRemove => s.Equals(pathToRemove, StringComparison.InvariantCulture));
+            };
+            var projectFile = ProjectSystem.ProjectFile.FromFile(ProjectFilePath);
+            _project = ProjectSystem.removeCompileNodesWithMissingFiles(fileExists.Convert(), projectFile);
+        };
+
+        It should_delete_missing_files_in_csharpapp = () =>
+        {
+            _project.Files.ShouldNotContain(new []{"Class1.cs", @"Folder\FolderFile2.cs"});
+            _project.Files.ShouldContain(new [] {@"Folder\FolderFile1.cs", @"Program.cs", @"Properties\AssemblyInfo.cs"});
+        };
+    }
 }
\ No newline at end of file
diff --git a/src/test/Test.FAKECore/ProjectTestFiles/CSharpApp.csproj b/src/test/Test.FAKECore/ProjectTestFiles/CSharpApp.csproj
new file mode 100644
index 00000000000..3a00b8119a3
--- /dev/null
+++ b/src/test/Test.FAKECore/ProjectTestFiles/CSharpApp.csproj
@@ -0,0 +1,62 @@
+<?xml version="1.0" encoding="utf-8"?>
+<Project ToolsVersion="14.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
+  <Import Project="$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props" Condition="Exists('$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props')" />
+  <PropertyGroup>
+    <Configuration Condition=" '$(Configuration)' == '' ">Debug</Configuration>
+    <Platform Condition=" '$(Platform)' == '' ">AnyCPU</Platform>
+    <ProjectGuid>{5C1A3730-057D-4C82-AF8B-32135611CB4B}</ProjectGuid>
+    <OutputType>Exe</OutputType>
+    <AppDesignerFolder>Properties</AppDesignerFolder>
+    <RootNamespace>ConsoleApplication2</RootNamespace>
+    <AssemblyName>ConsoleApplication2</AssemblyName>
+    <TargetFrameworkVersion>v4.5</TargetFrameworkVersion>
+    <FileAlignment>512</FileAlignment>
+  </PropertyGroup>
+  <PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Debug|AnyCPU' ">
+    <PlatformTarget>AnyCPU</PlatformTarget>
+    <DebugSymbols>true</DebugSymbols>
+    <DebugType>full</DebugType>
+    <Optimize>false</Optimize>
+    <OutputPath>bin\Debug\</OutputPath>
+    <DefineConstants>DEBUG;TRACE</DefineConstants>
+    <ErrorReport>prompt</ErrorReport>
+    <WarningLevel>4</WarningLevel>
+  </PropertyGroup>
+  <PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Release|AnyCPU' ">
+    <PlatformTarget>AnyCPU</PlatformTarget>
+    <DebugType>pdbonly</DebugType>
+    <Optimize>true</Optimize>
+    <OutputPath>bin\Release\</OutputPath>
+    <DefineConstants>TRACE</DefineConstants>
+    <ErrorReport>prompt</ErrorReport>
+    <WarningLevel>4</WarningLevel>
+  </PropertyGroup>
+  <ItemGroup>
+    <Reference Include="System" />
+    <Reference Include="System.Core" />
+    <Reference Include="System.Xml.Linq" />
+    <Reference Include="System.Data.DataSetExtensions" />
+    <Reference Include="Microsoft.CSharp" />
+    <Reference Include="System.Data" />
+    <Reference Include="System.Net.Http" />
+    <Reference Include="System.Xml" />
+  </ItemGroup>
+  <ItemGroup>
+    <Compile Include="Class1.cs" />
+    <Compile Include="Folder\FolderFile1.cs" />
+    <Compile Include="Folder\FolderFile2.cs" />
+    <Compile Include="Program.cs" />
+    <Compile Include="Properties\AssemblyInfo.cs" />
+  </ItemGroup>
+  <ItemGroup>
+    <None Include="App.config" />
+  </ItemGroup>
+  <Import Project="$(MSBuildToolsPath)\Microsoft.CSharp.targets" />
+  <!-- To modify your build process, add your task inside one of the targets below and uncomment it. 
+       Other similar extension points exist, see Microsoft.Common.targets.
+  <Target Name="BeforeBuild">
+  </Target>
+  <Target Name="AfterBuild">
+  </Target>
+  -->
+</Project>
\ No newline at end of file
diff --git a/src/test/Test.FAKECore/Test.FAKECore.csproj b/src/test/Test.FAKECore/Test.FAKECore.csproj
index 335ed661cd9..c6ba205bb58 100644
--- a/src/test/Test.FAKECore/Test.FAKECore.csproj
+++ b/src/test/Test.FAKECore/Test.FAKECore.csproj
@@ -203,6 +203,9 @@
     <Content Include="NAVFiles\Table_4.txt">
       <CopyToOutputDirectory>Always</CopyToOutputDirectory>
     </Content>
+    <None Include="ProjectTestFiles\CSharpApp.csproj">
+      <CopyToOutputDirectory>Always</CopyToOutputDirectory>
+    </None>
     <Content Include="SideBySideSpecification\Project1.txt">
       <CopyToOutputDirectory>Always</CopyToOutputDirectory>
     </Content>