Antispam feature add header and rewrite_subject does not work

[feiaweng]

As a rule of thumb: before reporting an issue

• see if it hasn't been reported (and possibly already been fixed) first
• try with the git master

Describe the bug
The add header value and rewrite_subject are the same. This does not work. In this case only the add header will be performed.
The settings must be different.
Example:
add header = 6.9;
rewrite_subject = 7;
In Froxlor is only one setting in database configurable.
Please change it to different values, than it will work.

System information

• Froxlor version: $version/$gitSHA1
• Web server: apache2/nginx/lighttpd
• DNS server: Bind/PowerDNS (standalone)/PowerDNS (Bind-backend)
• POP/IMAP server: Courier/Dovecot
• SMTP server: postfix/exim
• FTP server: proftpd/pureftpd
• OS/Version: ...

To Reproduce
Steps to reproduce the behavior:

1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Logfiles
If applicable, add log-entries to help explain your problem.

Additional context
Add any other context about the problem here.

[d00p]

Does the following patch resolve the issue?

diff --git a/lib/Froxlor/Cron/Mail/Rspamd.php b/lib/Froxlor/Cron/Mail/Rspamd.php
index ece47766..624e91dd 100644
--- a/lib/Froxlor/Cron/Mail/Rspamd.php
+++ b/lib/Froxlor/Cron/Mail/Rspamd.php
@@ -185,7 +185,7 @@ class Rspamd
                                $this->frx_settings_file .= '   apply {' . "\n";
                                $this->frx_settings_file .= '           actions {' . "\n";
                                $this->frx_settings_file .= '                   "add header" = ' . $email['spam_tag_level'] . ';' . "\n";
-                               $this->frx_settings_file .= '                   rewrite_subject = ' . $email['spam_tag_level'] . ';' . "\n";
+                               $this->frx_settings_file .= '                   rewrite_subject = ' . ($email['spam_tag_level'] + 0.01) . ';' . "\n";
                                $this->frx_settings_file .= '                   reject = ' . $email['spam_kill_level'] . ';' . "\n";
                                if ($type == 'rcpt' && (int)$email['policy_greylist'] == 0) {
                                        $this->frx_settings_file .= '                   greylist = null;' . "\n";

[feiaweng]

The only change I see is the green line. Have changed it in the Rspamd.php, but no changes in froxlor_settings.conf.
"add header" = 7; rewrite_subject = 7;

[d00p]

Well you need to force regeneration of the config files...bin/froxlor-cli froxlor:cron -fd in your froxlor install directory

[feiaweng]

I did the job froxlor-cron-with-debug, but with bin/froxlor-cli froxlor:cron -fd it has changed now.
Thanks