Fix storyboard sprites leaving gaps on edges when resolving from an atlas

frenzibyte · frenzibyte · commit c4141fff07a4 · 2024-07-17T14:47:17.000+03:00
diff --git a/osu.Game/Storyboards/Drawables/DrawableStoryboardSprite.cs b/osu.Game/Storyboards/Drawables/DrawableStoryboardSprite.cs
@@ -100,14 +100,15 @@ private void load(Storyboard storyboard)
                 skinSourceChanged();
             }
             else
-                Texture = textureStore.Get(Sprite.Path);
+                Texture = textureStore.Get(Sprite.Path, WrapMode.ClampToEdge, WrapMode.ClampToEdge);
 
             Sprite.ApplyTransforms(this);
         }
 
         private void skinSourceChanged()
         {
-            Texture = skin.GetTexture(Sprite.Path) ?? textureStore.Get(Sprite.Path);
+            Texture = skin.GetTexture(Sprite.Path, WrapMode.ClampToEdge, WrapMode.ClampToEdge) ??
+                      textureStore.Get(Sprite.Path, WrapMode.ClampToEdge, WrapMode.ClampToEdge);
 
             // Setting texture will only update the size if it's zero.
             // So let's force an explicit update.

Original file line number	Diff line number	Diff line change
`@@ -100,14 +100,15 @@ private void load(Storyboard storyboard)`
`100`	`100`	`skinSourceChanged();`
`101`	`101`	`}`
`102`	`102`	`else`
`103`		`- Texture = textureStore.Get(Sprite.Path);`
	`103`	`+ Texture = textureStore.Get(Sprite.Path, WrapMode.ClampToEdge, WrapMode.ClampToEdge);`
`104`	`104`
`105`	`105`	`Sprite.ApplyTransforms(this);`
`106`	`106`	`}`
`107`	`107`
`108`	`108`	`private void skinSourceChanged()`
`109`	`109`	`{`
`110`		`- Texture = skin.GetTexture(Sprite.Path) ?? textureStore.Get(Sprite.Path);`
	`110`	`+ Texture = skin.GetTexture(Sprite.Path, WrapMode.ClampToEdge, WrapMode.ClampToEdge) ??`
	`111`	`+ textureStore.Get(Sprite.Path, WrapMode.ClampToEdge, WrapMode.ClampToEdge);`
`111`	`112`
`112`	`113`	`// Setting texture will only update the size if it's zero.`
`113`	`114`	`// So let's force an explicit update.`