Work thread: add some logs when exception is caught

Fixes #143

Author: fremag

MemoScope/Core/ClrDump.cs

@@ -65,11 +65,16 @@ public ClrDump(DataTarget target, string dumpPath, MessageBus msgBus)
             DumpPath = dumpPath;
             MessageBus = msgBus;
             worker = new SingleThreadWorker(dumpPath);
-            worker.Run(InitRuntime);
+            worker.Run(InitRuntime, OnError);
 
             ClrDumpInfo = ClrDumpInfo.Load(dumpPath);
         }
 
+        private void OnError(Exception ex)
+        {
+            MessageBus.Log(this, "Failed to initRuntime: " + DumpPath, ex);
+        }
+
         public void InitCache(CancellationToken token)
         {
             cache = new ClrDumpCache(this);
@@ -105,7 +110,7 @@ internal void Dispose()
             logger.Debug("Cache dispose");
             cache.Dispose();
             logger.Debug("Runtime.DataTarget.Dispose");
-            Run( () => Runtime.DataTarget.Dispose());
+            Run( () => Runtime?.DataTarget?.Dispose());
             logger.Debug("Worker.Dispose");
             worker.Dispose();
         }

MemoScope/Core/ProcessInfo/ClrDumpInfo.cs

@@ -5,7 +5,6 @@
 using System.Diagnostics;
 using System.Collections.Generic;
 using System.Linq;
-using System;
 
 namespace MemoScope.Core.ProcessInfo
 {

MemoScope/Core/SimpleTask.cs

@@ -7,22 +7,32 @@ public class SimpleTask
     {
         public Action Work { get; }
         public Action Callback { get; }
+        public Action<Exception> OnError { get; }
+
         public TaskScheduler Scheduler { get; }
 
-        public SimpleTask(Action work, Action callback) : this(work, callback, null)
+        public SimpleTask(Action work, Action callback) : this(work, callback,null, null)
         {
         }
 
         public SimpleTask(Action work) : this(work, null)
         {
-            
         }
 
-        public SimpleTask(Action work, Action callback, TaskScheduler sched) 
+        public SimpleTask(Action work, Action callback, TaskScheduler sched)  : this(work, callback, null, sched)
+        {
+        }
+
+        public SimpleTask(Action work, Action callback, Action<Exception> onError)  : this(work, callback, onError, null)
+        {
+        }
+
+        public SimpleTask(Action work, Action callback, Action<Exception> onError, TaskScheduler sched)
         {
             Work = work;
             Callback = callback;
             Scheduler = sched;
+            OnError = onError;
         }
     }
 }

MemoScope/Core/SingleThreadWorker.cs

@@ -40,8 +40,9 @@ private void Run()
                 {
                     task.Work();
                 }
-                catch (Exception)
+                catch (Exception e)
                 {
+                    task.OnError?.Invoke(e);
                 }
                 if (task.Callback != null)
                 {
@@ -51,8 +52,9 @@ private void Run()
                         {
                             task.Callback();
                         }
-                        catch (Exception)
+                        catch (Exception ex)
                         {
+                            task.OnError?.Invoke(ex);
                         }
                     };
                     if (task.Scheduler == null)
@@ -83,6 +85,12 @@ public void Run(Action work)
             queue.Add(new SimpleTask(work, () => myEvent.Set()));
             myEvent.WaitOne();
         }
+        public void Run(Action work, Action<Exception> onError=null)
+        {
+            ManualResetEvent myEvent = new ManualResetEvent(false);
+            queue.Add(new SimpleTask(work, () => myEvent.Set(), onError));
+            myEvent.WaitOne();
+        }
 
         public T Eval<T>(Func<T> func)
         {

MemoScope/Modules/TypeStats/TypeStatModule.cs

@@ -43,8 +43,15 @@ public void Setup(ClrDump clrDump)
         public override void  Init()
         {
             Log("Computing type statistics...", WinFwk.UITools.Log.LogLevelType.Info);
-            typeStats = ClrDump.GetTypeStats();
-            Summary = $"{typeStats.Count:###,###,###,##0} types";
+            if (ClrDump.Runtime != null)
+            {
+                typeStats = ClrDump.GetTypeStats();
+                Summary = $"{typeStats.Count:###,###,###,##0} types";
+            }
+            else
+            {
+                Summary = $"Error. Dump file not loaded !";
+            }
             Log("Type statistics computed.", WinFwk.UITools.Log.LogLevelType.Info);
         }
 

MemoScope/Services/DumpLoaderService.cs

@@ -7,6 +7,7 @@
 using WinFwk.UIMessages;
 using WinFwk.UIServices;
 using System.Threading;
+using WinFwk.UITools.Log;
 
 namespace MemoScope.Services
 {
@@ -50,9 +51,12 @@ public void HandleMessage(OpenDumpRequest openDumpRequest)
                             EndTask("File loaded: " + fileInfo.FullName);
                         }
                     }
-                    catch
+                    catch(Exception ex) 
                     {
-                        target.Dispose();
+                        string msg = "Failed to load dump file: " + fileInfo.FullName;
+                        EndTask(msg);
+                        MessageBus.Log(this, msg, ex);
+                        target?.Dispose();
                         throw;
                     }
                 });