Added auth to VNC in test container, for OS X compatibility. #3824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zenmonkeykstop
requested review from
conorsch,
heartsucker,
msheiny and
redshiftzero
as code owners
|
Unable to fully test because of breaking changes also experienced in #3817 pertaining to tor browser bumps ... I mentioned using the archive version to test but @kushaldas brought up an excellent point that tor browser would just auto-update during testing and kaboom everything. |
|
Let's merge these changes over in #3817 (can we update the PR text over there to indicate this @zenmonkeykstop? - just for posterity) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
Updates #3721, adding OS X support. The built-in OS VNC client expects a password, so a file /tmp/vncpasswd is now created in the Docker test container and the VNC server and client commands have been updated according.
Testing
On OS X and within the working copy:
Once the container is set up and functional tests are running, from another terminal and the same location, run
make func-vncThe OS X VNC client should start, connected to the Docker VNC server on 127.0.0.1:5901.
On Debian/Ubuntu:
Repeat the steps above. The system VNC client should start connected to the Docker VNC server on <docker_ip>:5901
Deployment
Checklist
If you made non-trivial code changes: