Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid pyproject.toml (Qubes 4.3 - Fedora 41 in dom0) #1258

Open
deeplow opened this issue Feb 25, 2025 · 0 comments
Open

Invalid pyproject.toml (Qubes 4.3 - Fedora 41 in dom0) #1258

deeplow opened this issue Feb 25, 2025 · 0 comments

Comments

@deeplow
Copy link
Contributor

deeplow commented Feb 25, 2025

Description

Some pretty loud complaining in 4.2 build logs about impending pyproject.toml's strictness in project metadata. Fedora 41 (dom0's fedora version) this will actually break the build.

    ############################
    # Invalid `pyproject.toml` #
    ############################

    Any configurations in `pyproject.toml` will be ignored.
    Please note that future releases of setuptools will halt the build process
    if an invalid file is given.

    To prevent setuptools from considering `pyproject.toml` please
    DO NOT include the `[project]` or `[tool.setuptools]` tables in your file.

Steps to Reproduce

  1. Apply the following patch:
diff --git a/bootstrap/Dockerfile b/bootstrap/Dockerfile
index 5534bd6..359cd14 100644
--- a/bootstrap/Dockerfile
+++ b/bootstrap/Dockerfile
@@ -1,13 +1,13 @@
-FROM registry.fedoraproject.org/fedora:37
+FROM registry.fedoraproject.org/fedora:41
 LABEL org="Freedom of the Press"
-LABEL image_name="securedrop-workstation-qubes-4.2"
+LABEL image_name="securedrop-workstation-qubes-4.3"
  1. make build-rpm

Expected Behavior

Build succeeds

Actual Behavior

Build loudly fails:

Traceback (most recent call last):
  File "/home/user/securedrop-workstation/setup.py", line 9, in <module>
    setuptools.setup(
    ~~~~~~~~~~~~~~~~^
        name="securedrop-workstation-dom0-config",
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    ...<17 lines>...
        ],
        ^^
    )
    ^
  File "/usr/lib/python3.13/site-packages/setuptools/__init__.py", line 104, in setup
    return distutils.core.setup(**attrs)
           ~~~~~~~~~~~~~~~~~~~~^^^^^^^^^
  File "/usr/lib/python3.13/site-packages/setuptools/_distutils/core.py", line 159, in setup
    dist.parse_config_files()
    ~~~~~~~~~~~~~~~~~~~~~~~^^
  File "/usr/lib/python3.13/site-packages/setuptools/dist.py", line 631, in parse_config_files
    pyprojecttoml.apply_configuration(self, filename, ignore_option_errors)
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.13/site-packages/setuptools/config/pyprojecttoml.py", line 68, in apply_configuration
    config = read_configuration(filepath, True, ignore_option_errors, dist)
  File "/usr/lib/python3.13/site-packages/setuptools/config/pyprojecttoml.py", line 129, in read_configuration
    validate(subset, filepath)
    ~~~~~~~~^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.13/site-packages/setuptools/config/pyprojecttoml.py", line 57, in validate
    raise ValueError(f"{error}\n{summary}") from None
ValueError: invalid pyproject.toml config: `project`.
configuration error: `project` must contain ['name'] properties
Script done.
make: *** [Makefile:37: build-rpm] Error 1

Comments

References:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant