-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates CI to run on Buster for Debian packaging #616
Conversation
The My understanding was that we were going to keep the strech build job alongside the buster build job, same as we did for test-stretch & test-buster. Is that incorrect? |
b769a49
to
a65b8dc
Compare
After we revert freedomofpress/securedrop-builder#89 and redo the PR there, we can merge this one here. |
Kicked the CI to rerun. |
.circleci/config.yml
Outdated
./update_version.sh 1000.0 # Dummy version number, doesn't matter what we put here | ||
python3 setup.py sdist | ||
|
||
- run: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
want to make these run steps reusable by adding them to common-steps
above as YAML anchors and then referencing them here and in the below build-buster
job? (that way we keep these CI configs DRY)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will make this change, I never knew about YAML anchors before.
did you get a chance to look at this @kushaldas ? |
Nope, will finish that in the morning. |
a65b8dc
to
f6b1391
Compare
Updated the PR with the suggestions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Description
Fixes #527
Before this freedomofpress/securedrop-builder#89 needs to get merged. Then we will have to kick the CI for rebuild.
Test Plan