Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates CI to run on Buster for Debian packaging #616

Merged
merged 1 commit into from
Nov 27, 2019

Conversation

kushaldas
Copy link
Contributor

Description

Fixes #527

Before this freedomofpress/securedrop-builder#89 needs to get merged. Then we will have to kick the CI for rebuild.

Test Plan

./update_version.sh 1000.0  # Dummy version number, doesn't matter what we put here python3 setup.py sdist
cd ../securedrop-debian-packaging
export PKG_VERSION=1000.0
export PKG_PATH=/home/circleci/project/dist/securedrop-client-$PKG_VERSION.tar.gz
make securedrop-client

@eloquence
Copy link
Member

The build-stretch failure reported in CI is real as the job no longer exists in the config file.

My understanding was that we were going to keep the strech build job alongside the buster build job, same as we did for test-stretch & test-buster. Is that incorrect?

@kushaldas
Copy link
Contributor Author

After we revert freedomofpress/securedrop-builder#89 and redo the PR there, we can merge this one here.

@kushaldas
Copy link
Contributor Author

Kicked the CI to rerun.

./update_version.sh 1000.0 # Dummy version number, doesn't matter what we put here
python3 setup.py sdist

- run:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

want to make these run steps reusable by adding them to common-steps above as YAML anchors and then referencing them here and in the below build-buster job? (that way we keep these CI configs DRY)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will make this change, I never knew about YAML anchors before.

@redshiftzero
Copy link
Contributor

did you get a chance to look at this @kushaldas ?

@kushaldas
Copy link
Contributor Author

did you get a chance to look at this @kushaldas ?

Nope, will finish that in the morning.

@kushaldas kushaldas force-pushed the sudo_ci_move_to_buster branch from a65b8dc to f6b1391 Compare November 27, 2019 11:09
@kushaldas
Copy link
Contributor Author

did you get a chance to look at this @kushaldas ?

Updated the PR with the suggestions.

Copy link
Contributor

@redshiftzero redshiftzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@redshiftzero redshiftzero merged commit 381104a into master Nov 27, 2019
@redshiftzero redshiftzero deleted the sudo_ci_move_to_buster branch November 27, 2019 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch CI jobs to Debian Buster/Python 3.7
3 participants